Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TC-DT-1.1] Fix Wild card read if thread diagnostic attributes on wifi devices. #28739

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[TC-DT-1.1] Fix Wild card read if thread diagnostic attributes on wifi devices. #28739

merged 1 commit into from
Aug 18, 2023

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Aug 17, 2023 •
edited
Loading

Issue:
TC-DT-1.1 wild card read would fail on our wifi platform running the doorlock app using the common data model config (.zap and .matter files). Other WiFi platforms probably encounter the same failure if they use common data models of the examples.

Fix:
In the case of non-thread devices that would have the ThreadDiagnostic Cluster enabled, we encode null (for nullable attributes) or the default values of the attributes instead of erroring the read command with CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE

@jmartinez-silabs
ThreadDiagnostic Cluster : Encode Null or default values of the attri…
7a6768e 
…butes for non thread device that would have the cluster enabled
@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

PR #28739: Size comparison from 30e4169 to 7a6768e

Increases above 0.2%:

platform target config section 30e4169 7a6768e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 962108 966494 4386 0.5
.debug_info 19439145 21097544 1658399 8.5
psoc6 all-clusters cy8ckit_062s2_43012 .debug_abbrev 1382576 1387270 4694 0.3
.debug_info 30284085 32085808 1801723 5.9
all-clusters-minimal cy8ckit_062s2_43012 .debug_abbrev 1285212 1289906 4694 0.4
.debug_info 27249649 29050886 1801237 6.6
light cy8ckit_062s2_43012 .debug_abbrev 1125436 1130126 4690 0.4
.debug_info 22387437 24187444 1800007 8.0
lock cy8ckit_062s2_43012 .debug_abbrev 1116899 1121365 4466 0.4
.debug_info 22302332 24008140 1705808 7.6
Increases (17 builds for cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 30e4169 7a6768e change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 616586 616906 320 0.1
.debug_abbrev 962108 966494 4386 0.5
.debug_aranges 109072 109184 112 0.1
.debug_frame 369896 370356 460 0.1
.debug_info 19439145 21097544 1658399 8.5
.debug_line 2814647 2820532 5885 0.2
.debug_loclists 1598059 1599816 1757 0.1
.debug_rnglists 100615 100712 97 0.1
.debug_str 3429756 3430123 367 0.0
.strtab 497700 498131 431 0.1
.symtab 293792 293984 192 0.1
.text 507860 508180 320 0.1
cyw30739 lock cyw930739m2evb_01 (read/write) 537999 538007 8 0.0
.app_xip_area 424393 424401 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1089784 1089960 176 0.0
.text 908824 909000 176 0.0
esp32 all-clusters-app c3devkit (read only) 1151594 1151784 190 0.0
.flash.text 1151594 1151784 190 0.0
m5stack (read only) 1193275 1193467 192 0.0
.flash.text 1187891 1188083 192 0.0
linux lock-app debug (read only) 4475817 4477129 1312 0.0
.rodata 248102 248454 352 0.1
.text 4018339 4019299 960 0.0
mbed lock-app-release cy8cproto_062_4343w (read/write) 2522984 2523176 192 0.0
.text 1485668 1485860 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1220720 1220736 16 0.0
text 845248 845252 4 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1338948 1339124 176 0.0
text 772288 772464 176 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1768748 1768988 240 0.0
.debug_abbrev 1382576 1387270 4694 0.3
.debug_aranges 144024 144136 112 0.1
.debug_frame 479764 480220 456 0.1
.debug_info 30284085 32085808 1801723 5.9
.debug_line 4151625 4158505 6880 0.2
.debug_loclists 2251840 2253587 1747 0.1
.debug_rnglists 142446 142543 97 0.1
.debug_str 4128722 4129089 367 0.0
.strtab 806287 806556 269 0.0
.symtab 501840 501968 128 0.0
.text 1565196 1565436 240 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1677556 1677844 288 0.0
.debug_abbrev 1285212 1289906 4694 0.4
.debug_aranges 137240 137352 112 0.1
.debug_frame 462528 462984 456 0.1
.debug_info 27249649 29050886 1801237 6.6
.debug_line 3962289 3969473 7184 0.2
.debug_loclists 2150670 2152427 1757 0.1
.debug_rnglists 135581 135678 97 0.1
.debug_str 3982913 3983637 724 0.0
.strtab 717396 717751 355 0.0
.symtab 467296 467456 160 0.0
.text 1475940 1476228 288 0.0
light cy8ckit_062s2_43012 (read/write) 1605644 1605932 288 0.0
.debug_abbrev 1125436 1130126 4690 0.4
.debug_aranges 127336 127448 112 0.1
.debug_frame 425572 426028 456 0.1
.debug_info 22387437 24187444 1800007 8.0
.debug_line 3527130 3533858 6728 0.2
.debug_loclists 1987127 1988885 1758 0.1
.debug_rnglists 125268 125365 97 0.1
.debug_str 3789850 3790574 724 0.0
.strtab 634730 635085 355 0.1
.symtab 430608 430768 160 0.0
.text 1410340 1410628 288 0.0
lock cy8ckit_062s2_43012 (read/write) 1639684 1639908 224 0.0
.debug_abbrev 1116899 1121365 4466 0.4
.debug_aranges 126264 126376 112 0.1
.debug_frame 421636 422092 456 0.1
.debug_info 22302332 24008140 1705808 7.6
.debug_line 3482696 3488998 6302 0.2
.debug_loclists 1967693 1969451 1758 0.1
.debug_rnglists 123469 123566 97 0.1
.debug_str 3754695 3755062 367 0.0
.strtab 609601 609870 269 0.0
.symtab 423056 423184 128 0.0
.text 1416852 1417076 224 0.0
telink lighting-app-factory-data tlsr9518adk80d text 693766 693768 2 0.0
ota-requestor-app tlsr9518adk80d text 612680 612684 4 0.0
pump-app tlsr9518adk80d text 596444 596446 2 0.0
pump-controller-app tlsr9518adk80d text 586908 586910 2 0.0
Decreases (9 builds for bl602, bl702, bl702l, efr32, telink)
platform target config section 30e4169 7a6768e change % change
bl602 lighting-app bl602 .text 1057910 1057908 -2 -0.0
bl702 lighting-app bl702 (read/write) 1167995 1167991 -4 -0.0
.debug_info 41524217 41524216 -1 -0.0
.text 955062 955060 -2 -0.0
bl702l lighting-app bl702l (read/write) 1153604 1153600 -4 -0.0
.debug_info 41525326 41525325 -1 -0.0
.text 943814 943812 -2 -0.0
efr32 lighting-app BRD4187C (read/write) 1036996 1036988 -8 -0.0
.text 869940 869932 -8 -0.0
telink light-switch-app tlsr9518adk80d text 618570 618568 -2 -0.0
lighting-app-rpc tlsr9518adk80d text 731186 731184 -2 -0.0
shell tlsr9518adk80d text 478834 478832 -2 -0.0
thermostat tlsr9518adk80d (read/write) 911332 911324 -8 -0.0
text 621930 621926 -4 -0.0
window-covering tlsr9518adk80d text 617242 617238 -4 -0.0
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 30e4169 7a6768e change % change
bl602 lighting-app bl602 (read/write) 1364962 1364962 0 0.0
.bss 73430 73430 0 0.0
.data 9560 9560 0 0.0
.text 1057910 1057908 -2 -0.0
bl602+rpc (read/write) 1412430 1412430 0 0.0
.bss 81470 81470 0 0.0
.data 9952 9952 0 0.0
.text 1089844 1089844 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1167995 1167991 -4 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41285 41285 0 0.0
.bss_psram 43232 43232 0 0.0
.comment 48 48 0 0.0
.data 3544 3544 0 0.0
.debug_abbrev 1567499 1567499 0 0.0
.debug_aranges 140392 140392 0 0.0
.debug_frame 516608 516608 0 0.0
.debug_info 41524217 41524216 -1 -0.0
.debug_line 5485483 5485483 0 0.0
.debug_loc 3566616 3566616 0 0.0
.debug_ranges 384688 384688 0 0.0
.debug_str 4014668 4014668 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107196 107196 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 589615 589615 0 0.0
.symtab 175792 175792 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955062 955060 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1266927 1266927 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43232 43232 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1744629 1744629 0 0.0
.debug_aranges 148936 148936 0 0.0
.debug_frame 545512 545512 0 0.0
.debug_info 46419659 46419659 0 0.0
.debug_line 5898005 5898005 0 0.0
.debug_loc 3772772 3772772 0 0.0
.debug_ranges 410440 410440 0 0.0
.debug_str 4434533 4434533 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121848 121848 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 652578 652578 0 0.0
.symtab 194720 194720 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029744 1029744 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1153604 1153600 -4 -0.0
.boot2 292 292 0 0.0
.bss 15988 15988 0 0.0
.bss_psram 77648 77648 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1569718 1569718 0 0.0
.debug_aranges 134896 134896 0 0.0
.debug_frame 496296 496296 0 0.0
.debug_info 41525326 41525325 -1 -0.0
.debug_line 5401177 5401177 0 0.0
.debug_loc 3502767 3502767 0 0.0
.debug_ranges 389896 389896 0 0.0
.debug_str 4027137 4027137 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 101080 101080 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 589830 589830 0 0.0
.symtab 175344 175344 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
943814 943812 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 616586 616906 320 0.1
(read/write) 207240 207240 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200680 200680 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 962108 966494 4386 0.5
.debug_aranges 109072 109184 112 0.1
.debug_frame 369896 370356 460 0.1
.debug_info 19439145 21097544 1658399 8.5
.debug_line 2814647 2820532 5885 0.2
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1598059 1599816 1757 0.1
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 100615 100712 97 0.1
.debug_str 3429756 3430123 367 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106602 106602 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 497700 498131 431 0.1
.symtab 293792 293984 192 0.1
.text 507860 508180 320 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 550567 550567 0 0.0
.app_xip_area 442017 442017 0 0.0
.bss 63568 63568 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 537999 538007 8 0.0
.app_xip_area 424393 424401 8 0.0
.bss 68600 68600 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574279 574279 0 0.0
.app_xip_area 466809 466809 0 0.0
.bss 62560 62560 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 549279 549279 0 0.0
.app_xip_area 438801 438801 0 0.0
.bss 65472 65472 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1012772 1012772 0 0.0
.bss 184204 184204 0 0.0
.data 2652 2652 0 0.0
.text 825896 825896 0 0.0
BRD4187C (read/write) 1036996 1036988 -8 -0.0
.bss 163788 163788 0 0.0
.data 3248 3248 0 0.0
.text 869940 869932 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1089784 1089960 176 0.0
.bss 178268 178268 0 0.0
.data 2672 2672 0 0.0
.text 908824 909000 176 0.0
window-app BRD4187C (read/write) 1108808 1108808 0 0.0
.bss 146828 146828 0 0.0
.data 3132 3132 0 0.0
.text 958828 958828 0 0.0
esp32 all-clusters-app c3devkit (read only) 1151594 1151784 190 0.0
(read/write) 1702676 1702676 0 0.0
.dram0.bss 78960 78960 0 0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 266896 266896 0 0.0
.flash.text 1151594 1151784 190 0.0
.iram0.text 75262 75262 0 0.0
m5stack (read only) 1193275 1193467 192 0.0
(read/write) 550878 550878 0 0.0
.dram0.bss 85328 85328 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 297872 297872 0 0.0
.flash.text 1187891 1188083 192 0.0
.iram0.text 123311 123311 0 0.0
k32w contact k32w0+release (read only) 591044 591044 0 0.0
(read/write) 87936 87936 0 0.0
.bss 71184 71184 0 0.0
.data 2128 2128 0 0.0
.text 590508 590508 0 0.0
light k32w0+release (read only) 589828 589828 0 0.0
(read/write) 87588 87588 0 0.0
.bss 70848 70848 0 0.0
.data 2116 2116 0 0.0
.text 589292 589292 0 0.0
lock k32w0+release (read only) 562180 562180 0 0.0
(read/write) 85388 85388 0 0.0
.bss 68704 68704 0 0.0
.data 2060 2060 0 0.0
.text 561644 561644 0 0.0
linux all-clusters-app debug (read only) 5519449 5519449 0 0.0
(read/write) 416760 416760 0 0.0
.bss 128704 128704 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 276712 276712 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1296 1296 0 0.0
.rodata 336176 336176 0 0.0
.text 4805187 4805187 0 0.0
all-clusters-minimal-app debug (read only) 4914209 4914209 0 0.0
(read/write) 231936 231936 0 0.0
.bss 126048 126048 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 94896 94896 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272486 272486 0 0.0
.text 4411331 4411331 0 0.0
bridge-app debug (read only) 2770849 2770849 0 0.0
(read/write) 132848 132848 0 0.0
.bss 51512 51512 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71408 71408 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214600 214600 0 0.0
.text 2378723 2378723 0 0.0
chip-tool debug (read only) 17564049 17564049 0 0.0
(read/write) 1036096 1036096 0 0.0
.bss 93752 93752 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 929896 929896 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 907377 907377 0 0.0
.text 14647219 14647219 0 0.0
chip-tool-ipv6only arm64 (read only) 16786660 16786660 0 0.0
(read/write) 1103416 1103416 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 967272 967272 0 0.0
.dynamic 512 512 0 0.0
.got 23192 23192 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 819824 819824 0 0.0
.text 13773096 13773096 0 0.0
lighting-app debug+rpc+ui (read only) 5242513 5242513 0 0.0
(read/write) 222088 222088 0 0.0
.bss 117744 117744 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92248 92248 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 337108 337108 0 0.0
.text 4663331 4663331 0 0.0
lock-app debug (read only) 4475817 4477129 1312 0.0
(read/write) 202936 202936 0 0.0
.bss 113360 113360 0 0.0
.data 3728 3728 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248102 248454 352 0.1
.text 4018339 4019299 960 0.0
ota-provider-app debug (read only) 4128585 4128585 0 0.0
(read/write) 191872 191872 0 0.0
.bss 113504 113504 0 0.0
.data 4000 4000 0 0.0
.data.rel.ro 68448 68448 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201190 201190 0 0.0
.text 3737075 3737075 0 0.0
ota-requestor-app debug (read only) 4222481 4222481 0 0.0
(read/write) 196184 196184 0 0.0
.bss 114560 114560 0 0.0
.data 4240 4240 0 0.0
.data.rel.ro 71448 71448 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204582 204582 0 0.0
.text 3823251 3823251 0 0.0
shell debug (read only) 2939929 2939929 0 0.0
(read/write) 151040 151040 0 0.0
.bss 60008 60008 0 0.0
.data 784 784 0 0.0
.data.rel.ro 84376 84376 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 212562 212562 0 0.0
.text 2556258 2556258 0 0.0
thermostat-no-ble arm64 (read only) 4452052 4452052 0 0.0
(read/write) 243848 243848 0 0.0
.bss 122280 122280 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 102232 102232 0 0.0
.dynamic 512 512 0 0.0
.got 11984 11984 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 162236 162236 0 0.0
.text 3951736 3951736 0 0.0
tv-app debug (read only) 5317617 5317617 0 0.0
(read/write) 349856 349856 0 0.0
.bss 241280 241280 0 0.0
.data 5104 5104 0 0.0
.data.rel.ro 96048 96048 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272534 272534 0 0.0
.text 4801443 4801443 0 0.0
tv-casting-app debug (read only) 8297113 8297113 0 0.0
(read/write) 210576 210576 0 0.0
.bss 54208 54208 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147016 147016 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 367772 367772 0 0.0
.text 7529155 7529155 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522984 2523176 192 0.0
.bss 219408 219408 0 0.0
.data 5128 5128 0 0.0
.text 1485668 1485860 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1220720 1220736 16 0.0
bss 154482 154482 0 0.0
rodata 142036 142036 0 0.0
text 845248 845252 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1338948 1339124 176 0.0
bss 139940 139940 0 0.0
rodata 136028 136028 0 0.0
text 772288 772464 176 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1159924 1159924 0 0.0
bss 154680 154680 0 0.0
rodata 113728 113728 0 0.0
text 812552 812552 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 838176 838176 0 0.0
(read/write) 1768748 1768988 240 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 192628 192628 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2536 2536 0 0.0
.debug_abbrev 1382576 1387270 4694 0.3
.debug_aranges 144024 144136 112 0.1
.debug_frame 479764 480220 456 0.1
.debug_info 30284085 32085808 1801723 5.9
.debug_line 4151625 4158505 6880 0.2
.debug_line_str 957 957 0 0.0
.debug_loclists 2251840 2253587 1747 0.1
.debug_rnglists 142446 142543 97 0.1
.debug_str 4128722 4129089 367 0.0
.heap 838176 838176 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 806287 806556 269 0.0
.symtab 501840 501968 128 0.0
.text 0 0 0 0.0
1565196 1565436 240 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840112 840112 0 0.0
(read/write) 1677556 1677844 288 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190764 190764 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1285212 1289906 4694 0.4
.debug_aranges 137240 137352 112 0.1
.debug_frame 462528 462984 456 0.1
.debug_info 27249649 29050886 1801237 6.6
.debug_line 3962289 3969473 7184 0.2
.debug_line_str 981 981 0 0.0
.debug_loclists 2150670 2152427 1757 0.1
.debug_rnglists 135581 135678 97 0.1
.debug_str 3982913 3983637 724 0.0
.heap 840112 840112 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 717396 717751 355 0.0
.symtab 467296 467456 160 0.0
.text 1475940 1476228 288 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846424 846424 0 0.0
(read/write) 1605644 1605932 288 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184564 184564 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1125436 1130126 4690 0.4
.debug_aranges 127336 127448 112 0.1
.debug_frame 425572 426028 456 0.1
.debug_info 22387437 24187444 1800007 8.0
.debug_line 3527130 3533858 6728 0.2
.debug_line_str 942 942 0 0.0
.debug_loclists 1987127 1988885 1758 0.1
.debug_rnglists 125268 125365 97 0.1
.debug_str 3789850 3790574 724 0.0
.heap 846424 846424 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 634730 635085 355 0.1
.symtab 430608 430768 160 0.0
.text 1410340 1410628 288 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818896 818896 0 0.0
(read/write) 1639684 1639908 224 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212076 212076 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1116899 1121365 4466 0.4
.debug_aranges 126264 126376 112 0.1
.debug_frame 421636 422092 456 0.1
.debug_info 22302332 24008140 1705808 7.6
.debug_line 3482696 3488998 6302 0.2
.debug_line_str 933 933 0 0.0
.debug_loclists 1967693 1969451 1758 0.1
.debug_rnglists 123469 123566 97 0.1
.debug_str 3754695 3755062 367 0.0
.heap 818896 818896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 609601 609870 269 0.0
.symtab 423056 423184 128 0.0
.text 1416852 1417076 224 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178460 1178460 0 0.0
.bss 101016 101016 0 0.0
.data 744 744 0 0.0
.text 625304 625304 0 0.0
lock-app qpg6105+debug (read/write) 1135524 1135524 0 0.0
.bss 95736 95736 0 0.0
.data 748 748 0 0.0
.text 582364 582364 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1072684 1072684 0 0.0
bss 107176 107176 0 0.0
text 730922 730922 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 980404 980404 0 0.0
bss 105168 105168 0 0.0
text 672526 672526 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944736 944736 0 0.0
bss 109500 109500 0 0.0
text 647450 647450 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876692 876692 0 0.0
bss 98680 98680 0 0.0
text 590840 590840 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 907996 907996 0 0.0
bss 99304 99304 0 0.0
text 618570 618568 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 983032 983032 0 0.0
bss 107356 107356 0 0.0
text 686252 686252 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 994396 994396 0 0.0
bss 111604 111604 0 0.0
text 693766 693768 2 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1052564 1052564 0 0.0
bss 108928 108928 0 0.0
text 731186 731184 -2 -0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1084108 1084108 0 0.0
bss 120004 120004 0 0.0
text 751460 751460 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934684 934684 0 0.0
bss 99408 99408 0 0.0
text 621900 621900 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899272 899272 0 0.0
bss 99988 99988 0 0.0
text 612680 612684 4 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882092 882092 0 0.0
bss 98812 98812 0 0.0
text 596444 596446 2 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869272 869272 0 0.0
bss 98612 98612 0 0.0
text 586908 586910 2 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744420 744420 0 0.0
bss 97208 97208 0 0.0
text 478834 478832 -2 -0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879308 879308 0 0.0
bss 98800 98800 0 0.0
text 594320 594320 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865452 865452 0 0.0
bss 98520 98520 0 0.0
text 582554 582554 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 911332 911324 -8 -0.0
bss 99064 99064 0 0.0
text 621930 621926 -4 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 907132 907132 0 0.0
bss 99400 99400 0 0.0
text 617242 617238 -4 -0.0

@ReneJosefsen
Copy link
Contributor

To my understanding a wi-fi based device is not allowed to have the Thread network diag cluster in the server list, so ideally we should not need this work-around and instead we should fix the zap files to actually match the spec?

@jmartinez-silabs
Copy link
Member Author

@ReneJosefsen

we should not need this work-around and instead we should fix the zap files to actually match the spec?

The only way to do that would be for each different manufacturer, or at least each different network platform to create and use its own zap file for the example instead of the current status where a common file is used.

Based on the conversations, I believe this is currently the best option.

@mergify mergify bot merged commit 8bcda6a into project-chip:master Aug 18, 2023
@ReneJosefsen
Copy link
Contributor

@ReneJosefsen

we should not need this work-around and instead we should fix the zap files to actually match the spec?

The only way to do that would be for each different manufacturer, or at least each different network platform to create and use its own zap file for the example instead of the current status where a common file is used.

Based on the conversations, I believe this is currently the best option.

I understand, but the issue is if we are actually violating the spec by having Thread Diag enabled on devices that does not support Thread, If this is the case, I would argue we would need to (and properly should) do different zap files depending on the network interfaces.

@jmartinez-silabs jmartinez-silabs deleted the fix/non_thread_diagnostic_support branch August 18, 2023 19:06
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@jmartinez-silabs @HunsupJung
ThreadDiagnostic Cluster : Encode Null or default values of the attri…
b53db61 
…butes for non thread device that would have the cluster enabled (project-chip#28739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecille cecille cecille approved these changes

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmartinez-silabs @ReneJosefsen @cecille @mkardous-silabs