[ICD]Add unit tests for the ICD Manager operational states #28729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #28729: Size comparison from d0da504 to 5bf71ea Increases (7 builds for psoc6, telink)
Decreases (14 builds for bl602, bl702, bl702l, efr32, psoc6, telink)
Full report (55 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg, telink)
|
There was a problem hiding this comment.
As a side comment, by the BUILD.gn current setup, we are currently testing everything in icd/ except the IcdManagementServer, are we planing to to a specific unit test .cpp for it? Otherwise could we just have a TestICD.cpp and add the dependency to server-srcs in tests/BUILD.gn to allow placing the test in here as well?
lpbeliveau-silabs
approved these changes
Aug 17, 2023
a2e15ab to
25dfa2e
Compare
|
PR #28729: Size comparison from d0da504 to 25dfa2e Increases (5 builds for psoc6, telink)
Decreases (13 builds for bl602, bl702, efr32, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
25dfa2e to
623f232
Compare
|
PR #28729: Size comparison from e8cb4ff to b0a6248 Increases (10 builds for bl702, bl702l, psoc6, telink)
Decreases (4 builds for bl602, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Aug 21, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…hip#28729) * Add unit tests for the ICD Manager * Address comment, try to fix test for ESP and IOT SDK * Use GetIOContext().DriveIO() to run event loop. Set the systemLayer for test to be the IOContext one * Clean up * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…hip#28729) * Add unit tests for the ICD Manager * Address comment, try to fix test for ESP and IOT SDK * Use GetIOContext().DriveIO() to run event loop. Set the systemLayer for test to be the IOContext one * Clean up * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for ICD Manager