-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RVCOPSTATE-2.3] Add a check for PICS #28588
[RVCOPSTATE-2.3] Add a check for PICS #28588
Conversation
PR #28588: Size comparison from 4f658f6 to 029cf68 Increases (5 builds for bl602, esp32, telink)
Decreases (12 builds for bl702, cc32xx, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28588: Size comparison from 4f658f6 to e5fdffe Increases above 0.2%:
Increases (40 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (7 builds for cc32xx, linux, psoc6)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28588: Size comparison from 4f658f6 to dbdfa94 Increases above 0.2%:
Increases (29 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (6 builds for cc32xx, linux, psoc6)
Full report (31 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28588: Size comparison from 4f658f6 to 738e986 Increases above 0.2%:
Increases (39 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (7 builds for cc32xx, linux, psoc6)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
This reverts commit dbdfa94.
PR #28588: Size comparison from 71aa96f to 041bd1d Increases (12 builds for bl702, k32w, nrfconnect, psoc6, telink)
Decreases (9 builds for bl702l, efr32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* check for countdowntime pics * clean up * address comments * address comments * address comments * Revert "address comments" This reverts commit dbdfa94. * add check for RVCOPSTATE.S.M.ST_RUNNING * remove the check for paused and running pics
Added a check for:
RVCOPSTATE.S.A0002
before reading theCountDowntime
attributeFixes #28579