-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing validity checks to GroupKeyManagement cluster #28379
Add missing validity checks to GroupKeyManagement cluster #28379
Conversation
Problem: - GroupKeyManagement cluster did not enforce length checks on EpochKey0/1/2 - Some corner cases of checks were not covered. - Spec fixed in https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/7342 - Fixes project-chip#28222 This PR: - Adds all the missing checks that spec updates imply - Adds tests for each of the individual checks - Adds improved logging for failures Testing done: - New integration tests added - Integration tests pass
PR #28379: Size comparison from 7baabb7 to 8cf8140 Increases above 0.2%:
Increases (13 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, qpg)
Decreases (2 builds for k32w)
Full report (14 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, qpg)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but please sort out the compile issue in the cluster revision read.
src/app/clusters/group-key-mgmt-server/group-key-mgmt-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/group-key-mgmt-server/group-key-mgmt-server.cpp
Outdated
Show resolved
Hide resolved
PR #28379: Size comparison from 7baabb7 to 34d0747 Increases above 0.2%:
Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for k32w)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28379: Size comparison from 7baabb7 to aebd3cf Increases above 0.2%:
Increases (28 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (2 builds for k32w)
Full report (29 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28379: Size comparison from c96ffaa to 526e4fc Increases above 0.2%:
Increases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for k32w, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28379: Size comparison from c96ffaa to 5cf6acc Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for k32w)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Problem:
This PR:
Testing done: