-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly call the EndianPutSigned for signed integers. #28374
Merged
mergify
merged 3 commits into
project-chip:master
from
dysonltd:fix_SetSafeAttributePersistenceProvider_WriteScalarValue
Aug 8, 2023
Merged
Explicitly call the EndianPutSigned for signed integers. #28374
mergify
merged 3 commits into
project-chip:master
from
dysonltd:fix_SetSafeAttributePersistenceProvider_WriteScalarValue
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Jul 28, 2023
PR #28374: Size comparison from c1d26c0 to 8c7f96e Increases (11 builds for bl602, bl702l, cc32xx, cyw30739, esp32, telink)
Decreases (7 builds for bl702, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28374: Size comparison from 6c95a74 to 8a3320f Increases (10 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (10 builds for esp32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
p0fi
approved these changes
Aug 8, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
…p#28374) * Explicitly call the EndianPutSigned for signed integers. * Added constexpr to compile for Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
SafeAttributePersistenceProvider::WriteScalarValue
for certain platforms.