-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Constants.h to the secure_channel sources. #28219
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:secure_channel-deps
Jul 24, 2023
Merged
Add Constants.h to the secure_channel sources. #28219
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:secure_channel-deps
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes gn to correctly notice the circular dependencies between secure_channel and messaging and secure_channel and transport, which are inherent in the spec. Annotate those circular dependencies.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs and
mlepage-google
July 24, 2023 15:52
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
July 24, 2023 15:52
PR #28219: Size comparison from d328c30 to 4481bf1 Increases (8 builds for esp32, psoc6, telink)
Decreases (13 builds for bl602, bl702, bl702l, esp32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
robszewczyk
approved these changes
Jul 24, 2023
yunhanw-google
approved these changes
Jul 24, 2023
andy31415
reviewed
Jul 24, 2023
saurabhst
approved these changes
Jul 24, 2023
jmartinez-silabs
approved these changes
Jul 24, 2023
jtung-apple
approved these changes
Jul 24, 2023
This was referenced Jul 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes gn to correctly notice the circular dependencies between secure_channel and messaging and secure_channel and transport, which are inherent in the spec. Annotate those circular dependencies.