Update AppDelegate to report error param and callback for when session establishment starts #28138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdecenzo
approved these changes
Jul 21, 2023
fec5dfc to
5fba77c
Compare
cliffamzn
approved these changes
Jul 21, 2023
saurabhst
approved these changes
Jul 21, 2023
| class AppDelegate | ||
| { | ||
| public: | ||
| virtual ~AppDelegate() {} | ||
| /** | ||
| * This is called on start of session establishment process |
There was a problem hiding this comment.
This says nothing useful. What is considered the "start of the session establishment process" @sharadb-amazon? This specifically gets called when PBKDFParamRequest is received, right?
There was a problem hiding this comment.
Going to address it in this PR: #28186
| void OnCommissioningSessionStarted() override { bluetoothLED.Set(true); } | ||
| void OnCommissioningSessionStopped() override | ||
| void OnCommissioningSessionStopped(CHIP_ERROR err) override |
There was a problem hiding this comment.
This changes public API. This should have been a new callback for status in addition to OnCommissioningSessionStopped.
Furthermore, usage of the err argument is not documented.
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Aug 1, 2023
…n establishment starts (project-chip#28138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28136
Problem
As an app developer, I need a mechanism from the Matter SDK, to know at what point the establishment of a commissioning session started (say for some cues to the user during the commissioning process).
As an app developer, I need a mechanism from the Matter SDK, to know the error code for when a commissioning session stopped.
Solution
Updated the AppDelegate to allow for the above use cases. And called new callback from the CommissioningWIndowManager.