CASEServer: Register UMH for Sigma1 only on server startup #28064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
approved these changes
Jul 19, 2023
andy31415
reviewed
Jul 19, 2023
andy31415
approved these changes
Jul 19, 2023
|
@shubhamdp Please cherry-pick this fix on v1.1-branch |
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #27226, we are no longer unregistering the unsolicited message hander for sigma1. Based on handshake state and failure to schedule work, decide what to do:
But, the registration was happening on every CASE success or failure.
This change registers the UMH for sigma1 only on server startup.
Fixes Item (1) in #27474