-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exchange manager tests to handle losing timeslice better. #27872
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-exchange-mgr-test
Jul 11, 2023
Merged
Fix exchange manager tests to handle losing timeslice better. #27872
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-exchange-mgr-test
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could get into a situation where we lost the timeslice after the SendMessage call and before we asserted the response timeout had not happened yet, which would cause the test to fail. The changes here are: 1) Move the assert that we are not timed out to _before_ SendMessage(). This ensures that our state is correct up front, and generally nothing under SendMessage proper or sending the message should trigger a timeout per se. 2) Use more slack when waiting for the timeout, just in case. Fixes project-chip#27479
56c9863
to
aa60040
Compare
PR #27872: Size comparison from c7d9a11 to aa60040 Increases (19 builds for bl602, bl702, cc32xx, cyw30739, efr32, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl702l, efr32, esp32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jul 11, 2023
woody-apple
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could get into a situation where we lost the timeslice after the SendMessage call and before we asserted the response timeout had not happened yet, which would cause the test to fail.
The changes here are:
ensures that our state is correct up front, and generally nothing under
SendMessage proper or sending the message should trigger a timeout per se.
Fixes #27479