-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tracing for all linux app builds #27871
Merged
mergify
merged 3 commits into
project-chip:master
from
andy31415:more_tracing_for_linux
Jul 11, 2023
Merged
Enable tracing for all linux app builds #27871
mergify
merged 3 commits into
project-chip:master
from
andy31415:more_tracing_for_linux
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27871: Size comparison from c7d9a11 to ce6038a Increases (2 builds for cc32xx, qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
PR #27871: Size comparison from c7d9a11 to 63c8fa3 Increases above 0.2%:
Increases (11 builds for bl602, bl702, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, qpg)
Decreases (5 builds for bl702l, efr32, esp32, psoc6)
Full report (31 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #27871: Size comparison from c7d9a11 to e7e91db Increases above 0.2%:
Increases (20 builds for bl602, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for bl702, bl702l, efr32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 11, 2023
cecille
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables perfetto & json tracing in all example apps for linux.
Has the sideffect of enabling C++17 (because perfetto requires it). We may need to update the default if we find that C++17 features are used and break other platform builds. The PR assumes that most people do not often try to use C++17 features and if they do, CI will complain (downside is basically a slow feedback cycle in that case).