-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update websocket_runner keep alive timeout #27815
Merged
woody-apple
merged 1 commit into
project-chip:master
from
ccruzagralopes:update_websocket_runner_ping_timeout
Jul 7, 2023
Merged
Update websocket_runner keep alive timeout #27815
woody-apple
merged 1 commit into
project-chip:master
from
ccruzagralopes:update_websocket_runner_ping_timeout
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27815: Size comparison from a2a3712 to 8629058 Increases (10 builds for bl702l, cyw30739, esp32, nrfconnect, qpg, telink)
Decreases (15 builds for bl602, cc32xx, cyw30739, efr32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Context: Using the runner in Test Harness (chip-certification-tool).
Description: The web socket connection to the runner was timing out when pairing/commissioning failed during a test suite setup.
Steps to reproduce:
TC-ACE-1.1
) in Test Harnesschip-tool
pairing command times out, the runner web socket keep alive ping times out and closes the connection, causing a failure in THExpected behavior:
Solution
Increasing the keep alive ping timeout value solved the problem.
The new value was found through trial and error. The value 110 also worked, but I chose 120 just to be sure. Values <= 100 still caused the failure.