-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Implement ScanNetworks. #27623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27623: Size comparison from a9773c9 to abc4073 Increases (5 builds for bl702l, cyw30739, nrfconnect, psoc6)
Decreases (6 builds for bl602, bl702, cc32xx, cyw30739, esp32)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
38be9e1
to
77e6bcb
Compare
arkq
reviewed
Jul 9, 2023
8135bc3
to
e42d475
Compare
PR #27623: Size comparison from 0da8dc4 to e42d475 Increases (9 builds for esp32, psoc6, telink)
Decreases (14 builds for bl602, bl702, cc32xx, cyw30739, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
e42d475
to
b5e0e63
Compare
PR #27623: Size comparison from 01116da to b5e0e63 Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
arkq
requested changes
Jul 14, 2023
This pacth: -> Implements ScanNetworks function. -> Implements callback functions related to the ScanNetworks. -> Implements Count and Next function. -> Resolve race condition in ble-wifi commissioning. Signed-off-by: Akash Kumar <akash1.kumar@samsung.com>
b5e0e63
to
11f05c4
Compare
arkq
reviewed
Jul 17, 2023
Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com>
This pacth: -> Implements ScanNetworks function. -> Implements callback functions related to the ScanNetworks. -> Implements Count and Next function. -> Resolve race condition in ble-wifi commissioning. Signed-off-by: Akash Kumar <akash1.kumar@samsung.com>
6fb9298
to
475847e
Compare
Signed-off-by: Akash Kumar <akash1.kumar@samsung.com>
475847e
to
48c5c71
Compare
Looks good to me. |
dh79pyun
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
arkq
approved these changes
Jul 20, 2023
be85988
to
128e6c8
Compare
Signed-off-by: Akash Kumar <akash1.kumar@samsung.com>
128e6c8
to
fca21f2
Compare
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
* [Tizen] Implement ScanNetworks This pacth: -> Implements ScanNetworks function. -> Implements callback functions related to the ScanNetworks. -> Implements Count and Next function. -> Resolve race condition in ble-wifi commissioning. Signed-off-by: Akash Kumar <akash1.kumar@samsung.com> * Update src/platform/Tizen/WiFiManager.cpp Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> * Implement ScanNetworks This pacth: -> Implements ScanNetworks function. -> Implements callback functions related to the ScanNetworks. -> Implements Count and Next function. -> Resolve race condition in ble-wifi commissioning. Signed-off-by: Akash Kumar <akash1.kumar@samsung.com> * Update error handling Signed-off-by: Akash Kumar <akash1.kumar@samsung.com> --------- Signed-off-by: Akash Kumar <akash1.kumar@samsung.com> Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Implements ScanNetworks function.
Implements callback functions related to the ScanNetworks.
Implements TizenWiFiDriver:Count() and TizenWiFiDriver:Next() functions as well.
Resolve race condition in ble-wifi commissioning.
Testing