-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow device does not support any method for rendezvous #27557
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
yufengwangca:pr/onboarding/qrcode
Jun 30, 2023
Merged
Allow device does not support any method for rendezvous #27557
yufengwangca
merged 1 commit into
project-chip:master
from
yufengwangca:pr/onboarding/qrcode
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27557: Size comparison from a39e88a to 40bdfa5 Increases (11 builds for bl702, bl702l, psoc6, telink)
Decreases (2 builds for telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 29, 2023
tcarmelveilleux
approved these changes
Jun 29, 2023
PR #27557: Size comparison from def0efa to d139bea Increases (5 builds for psoc6, telink)
Decreases (13 builds for bl602, cc32xx, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, kotlin OnboardingPayload require QRCode at least support one method for rendezvous to be valid, this is not align with native SetupPayload implementation which allow RendezvousInformationFlag::kNone
/// The rendezvous type this device supports.
enum class RendezvousInformationFlag : uint8_t
{
kNone = 0, ///< Device does not support any method for rendezvous
kSoftAP = 1 << 0, ///< Device supports Wi-Fi softAP
kBLE = 1 << 1, ///< Device supports BLE
kOnNetwork = 1 << 2, ///< Device supports Setup on network
};
Update kotlin OnboardingPayload implementation to align with native implemenation