-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update server implemetation of refrigerator cluster to sync spec #27475
Update server implemetation of refrigerator cluster to sync spec #27475
Conversation
jadhavrohit924
commented
Jun 26, 2023
- Problem
- Changes
- Testing
@bzbarsky-apple spec didn't defined default value of supported attribute for refrigerator alarm as did for mask. What should we set? |
57c3077
to
b568c3c
Compare
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Show resolved
Hide resolved
PR #27475: Size comparison from 6ad0f1e to b568c3c Increases (14 builds for esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, bl702, k32w, nrfconnect, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Show resolved
Hide resolved
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Outdated
Show resolved
Hide resolved
That's a question for @marktrayer, I think... |
The spec states: Or am I missing something? |
That "default" value has nothing to do with what devices are expected to implement. Is it valid to have a refrigerator alarm cluster that has the door alarm bit set to false in Supported? |
I keep mixing up what default means (sorry!); the short answer is no. Even if suppressed, it's always supported. |
If we do this we need to set door alarm bit of Mask to false too. |
PR #27475: Size comparison from 6ad0f1e to 1f32cb4 Increases (2 builds for nrfconnect)
Full report (3 builds for nrfconnect)
|
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Show resolved
Hide resolved
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.h
Outdated
Show resolved
Hide resolved
1f32cb4
to
e05dde0
Compare
PR #27475: Size comparison from def0efa to e05dde0 Increases (17 builds for bl702l, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl602, bl702, cc32xx, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.cpp
Show resolved
Hide resolved
e05dde0
to
31260b9
Compare
PR #27475: Size comparison from a85c19f to 31260b9 Increases (19 builds for bl602, bl702, cc32xx, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl602, esp32, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|