Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timesync: Remove non-spec compliant step #27458

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Timesync: Remove non-spec compliant step #27458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 10 additions & 29 deletions src/python_testing/TC_TIMESYNC_2_7.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,68 +101,49 @@ async def test_TC_TIMESYNC_2_7(self):
local = await self.read_ts_attribute_expect_success(local_attr)
compare_time(received=local, offset=timedelta(seconds=3600), tolerance=timedelta(seconds=5))

self.print_step(10, "Send SetTimeZone")
th_utc = utc_time_in_matter_epoch()
tz = [tz_struct(offset=7200, validAt=th_utc+1e+7)]
ret = await self.send_set_time_zone_cmd(tz)
asserts.assert_true(ret.DSTOffsetRequired, "DSTOffsetRequired not set to true")

self.print_step(11, "Send SetDSTOffset command")
dst = [dst_struct(offset=0, validStarting=0, validUntil=NullValue)]
await self.send_set_dst_cmd(dst)

self.print_step(12, "Read LocalTime")
local = await self.read_ts_attribute_expect_success(local_attr)
compare_time(received=local, offset=timedelta(), tolerance=timedelta(seconds=5))

self.print_step(13, "Wait 15s then Read LocalTime")
time.sleep(15)
local = await self.read_ts_attribute_expect_success(local_attr)
compare_time(received=local, offset=timedelta(seconds=7200), tolerance=timedelta(seconds=5))

self.print_step(14, "Read TZ list size")
self.print_step(10, "Read TZ list size")
tz_list_size = await self.read_ts_attribute_expect_success(attributes.TimeZoneListMaxSize)

self.print_step(15, "Set time zone with two items")
self.print_step(11, "Set time zone with two items")
if tz_list_size > 1:
th_utc = utc_time_in_matter_epoch()
tz = [tz_struct(offset=3600, validAt=0), tz_struct(offset=7200, validAt=th_utc+1e+7)]

self.print_step(16, "Send SetDSTOffset command")
self.print_step(12, "Send SetDSTOffset command")
if tz_list_size > 1:
dst = [dst_struct(offset=0, validStarting=0, validUntil=NullValue)]
await self.send_set_dst_cmd(dst)

self.print_step(17, "Read LocalTime")
self.print_step(13, "Read LocalTime")
if tz_list_size > 1:
local = await self.read_ts_attribute_expect_success(local_attr)
compare_time(received=local, offset=timedelta(seconds=3600), tolerance=timedelta(seconds=5))

self.print_step(18, "Wait 15s and read LocalTime")
self.print_step(14, "Wait 15s and read LocalTime")
if tz_list_size > 1:
time.sleep(15)
local = await self.read_ts_attribute_expect_success(local_attr)
compare_time(received=local, offset=timedelta(seconds=7200), tolerance=timedelta(seconds=5))

self.print_step(19, "Send SetTimeZone with negative offset")
self.print_step(15, "Send SetTimeZone with negative offset")
tz = [tz_struct(offset=-3600, validAt=0)]
ret = await self.send_set_time_zone_cmd(tz)
asserts.assert_true(ret.DSTOffsetRequired, "DSTOffsetRequired not set to true")

self.print_step(20, "Send SetDSTOffset command")
self.print_step(16, "Send SetDSTOffset command")
dst = [dst_struct(offset=0, validStarting=0, validUntil=NullValue)]
await self.send_set_dst_cmd(dst)

self.print_step(21, "Read LocalTime")
self.print_step(17, "Read LocalTime")
local = await self.read_ts_attribute_expect_success(local_attr)
compare_time(received=local, offset=timedelta(seconds=-3600), tolerance=timedelta(seconds=5))

self.print_step(22, "Send SetTimeZone with 0 offset")
self.print_step(18, "Send SetTimeZone with 0 offset")
tz = [tz_struct(offset=0, validAt=0)]
ret = await self.send_set_time_zone_cmd(tz)
asserts.assert_true(ret.DSTOffsetRequired, "DSTOffsetRequired not set to true")

self.print_step(23, "Send SetDSTOffset command")
self.print_step(19, "Send SetDSTOffset command")
dst = [dst_struct(offset=0, validStarting=0, validUntil=NullValue)]
await self.send_set_dst_cmd(dst)

Expand Down