-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Config Option to enable/disable log filtering APIs #27012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
June 1, 2023 15:05
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple and
woody-apple
June 1, 2023 15:05
andy31415
approved these changes
Jun 1, 2023
PR #27012: Size comparison from 5589086 to 9b9bdf1 Increases (1 build for bl702)
Decreases (3 builds for bl602, bl702)
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
|
PR #27012: Size comparison from 5589086 to 1fd5f53 Increases (21 builds for bl602, bl702, cc32xx, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 1, 2023
shubhamdp
force-pushed
the
esp32_log_level
branch
from
June 2, 2023 04:12
1fd5f53
to
02a28de
Compare
PR #27012: Size comparison from 43cfe21 to 02a28de Increases (3 builds for telink)
Decreases (12 builds for bl702, cc32xx, cyw30739, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Also, - Removed the stale TODO
shubhamdp
force-pushed
the
esp32_log_level
branch
from
June 2, 2023 15:14
02a28de
to
34bf124
Compare
PR #27012: Size comparison from e19d9d8 to 34bf124 Increases (10 builds for bl702, esp32, psoc6, telink)
Decreases (11 builds for bl602, cyw30739, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jun 2, 2023
chshu
approved these changes
Jun 5, 2023
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jun 5, 2023
…hip#27012) * [ESP32] Option to enable/disable log filtering APIs Also, - Removed the stale TODO * Fix the kconfig help to match with default value
andy31415
pushed a commit
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
Exposing an option to use the log filtering APIs.
Tests
SetLogFilter(kLogCategory_Error)
inexamples/lighting-app/esp32/main/main.cpp