【Feature】dishwasher operational state cluster xml #26949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #26949: Size comparison from 25ba372 to a7f6e3b Increases above 0.2%:
Increases (25 builds for bl602, bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (14 builds for bl702, cc13x2_26x2, cc13x4_26x4, cyw30739, efr32, esp32, telink)
Full report (64 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
|
PR #26949: Size comparison from 5d913c9 to df902bc Increases above 0.2%:
Increases (23 builds for bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (18 builds for bl602, bl702, cyw30739, efr32, k32w, nrfconnect, telink)
Full report (44 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
|
Per Slack discussion: sharing an enum across clusters does not define any sort of shared enum definition, so a shared-across-clusters struct (which does have such a definition) does not compile because the shared enum definition it references does not exist. We need to figure out how to make all that work, but in the meantime we should just have separate structs for this cluster as the original PR had, and my apologies for the wasted time @mideayanghui |
I have reverted to the original PR. Thanks. |
|
PR #26949: Size comparison from 551651e to cc7d7d8 Increases above 0.2%:
Increases (34 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for esp32, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Is this still relevant given https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7070 ?
plauric
reviewed
Jun 8, 2023
src/app/zap-templates/zcl/data-model/chip/operational-state-dishwasher-cluster.xml
Show resolved
Hide resolved
plauric
reviewed
Jun 8, 2023
|
|
||
| <enum name="ErrorStateEnum" type="ENUM8"> | ||
| <cluster code="0x005A"/> | ||
| <item name="NoError" value="0x00"/> |
There was a problem hiding this comment.
Similar comment to my previous one. The values from the generic Operational State cluster (0x01 to 0x03) should not be redefined here. This enum should only include those specific to this cluster derivation (0x40 to 0x45).
Please see what was done for the Mode Select cluster and its derivations, in this merged PR:
https://github.com/project-chip/connectedhomeip/pull/26508/files#
src/app/zap-templates/zcl/data-model/chip/dishwasher-mode-select-cluster.xml
There was a problem hiding this comment.
Sorry, I'm not sure why this was marked as resolved. Please clarify.
plauric
reviewed
Jun 8, 2023
plauric
reviewed
Jun 8, 2023
plauric
reviewed
Jun 9, 2023
| <item name="UnableToStartOrResume" value="0x01"/> | ||
| <item name="UnableToCompleteOperation" value="0x02"/> | ||
| <item name="CommandInvalidInState" value="0x03"/> | ||
| <item name="InflowError" value="0x40"/> |
There was a problem hiding this comment.
Could you point me to where these Dishwasher specific errors are defined in the spec?
There was a problem hiding this comment.
They used to be there, then got removed in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7070
Hence my question above about what changes this XML needs as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperate the dishwasher operational state cluster XML to a new PR. Based on New XML and Code Gen for Appliance Clusters (OpState, TCC, RefAlm #26560 )
Problem:
Matter 1.2 clusters missing XML and generated code for dishwasher operational state cluster
Solution:
Create XML
Update zcl.json, zcl-with-test-extensions.json and related zap files.
Testing:
Regen all
Rebuild chip tool
Verify all new clusters are visible in chip-tool, with correct set of available attributes