[Happy] Enable happy test in pre-submit checks

[erjiaqing]

Problem

• Currently, Happy test framework was added to CHIP, but no tests are enabled.

Summary of Changes

• Follow-ups after [happy] Initial commit for adding Happy test #2319 is merged
• Wrapper for running happy tests in gn/ninja
• happy_test template
• Enables them in pre-submit checks
• Run all unit tests in gn_test
• Happy tests can be invoked by

  scripts/build/gn_gen.sh
  RUN_HAPPY_TESTS=1 scripts/tests/gn_tests.sh
  

• Move all unit tests to seperate github actions (unit_test).
• Logs are uploads to artifacts in github actions

fixes #2591

[mspang]

Marking request changes for removal of root access requirement and use of sudo when running the tests via ninja. Please ping me if next steps are not clear.

PR Updated, found sudo is not available when using user namespace, added a face_sudo.sh as a workaround.

Why is this required?

From happy source:

    def getRunAsRootPrefixList(self):
        if "SUDO" in list(os.environ.keys()):
            return [os.environ["SUDO"]]
        elif os.getuid() == 0:
            # We are already root
            return []
        else:
            return ["sudo"]

The getuid() check should work out, right?

[mspang]

Thanks, just a few more fixes..

[erjiaqing]

Marking request changes for removal of root access requirement and use of sudo when running the tests via ninja. Please ping me if next steps are not clear.

PR Updated, found sudo is not available when using user namespace, added a face_sudo.sh as a workaround.

Why is this required?

From happy source:

    def getRunAsRootPrefixList(self):
        if "SUDO" in list(os.environ.keys()):
            return [os.environ["SUDO"]]
        elif os.getuid() == 0:
            # We are already root
            return []
        else:
            return ["sudo"]

The getuid() check should work out, right?

In happy:

    def getRunAsUserPrefixList(self, username=None):
        if username is None:
            username = getpass.getuser()

        if "SUDO" in list(os.environ.keys()):
            return [os.environ["SUDO"], "-u", username]
        else:
            return ["sudo", "-u", username]

sudo is required here.

[mspang]

Marking request changes for removal of root access requirement and use of sudo when running the tests via ninja. Please ping me if next steps are not clear.

PR Updated, found sudo is not available when using user namespace, added a face_sudo.sh as a workaround.

Why is this required?
From happy source:

    def getRunAsRootPrefixList(self):
        if "SUDO" in list(os.environ.keys()):
            return [os.environ["SUDO"]]
        elif os.getuid() == 0:
            # We are already root
            return []
        else:
            return ["sudo"]

The getuid() check should work out, right?

In happy:

    def getRunAsUserPrefixList(self, username=None):
        if username is None:
            username = getpass.getuser()

        if "SUDO" in list(os.environ.keys()):
            return [os.environ["SUDO"], "-u", username]
        else:
            return ["sudo", "-u", username]

sudo is required here.

Can you file a bug against happy and put a TODO linking to it in CHIP ?

[mspang]

Marking request changes for removal of root access requirement and use of sudo when running the tests via ninja. Please ping me if next steps are not clear.

PR Updated, found sudo is not available when using user namespace, added a face_sudo.sh as a workaround.

Why is this required?
From happy source:

    def getRunAsRootPrefixList(self):
        if "SUDO" in list(os.environ.keys()):
            return [os.environ["SUDO"]]
        elif os.getuid() == 0:
            # We are already root
            return []
        else:
            return ["sudo"]

The getuid() check should work out, right?

In happy:

    def getRunAsUserPrefixList(self, username=None):
        if username is None:
            username = getpass.getuser()

        if "SUDO" in list(os.environ.keys()):
            return [os.environ["SUDO"], "-u", username]
        else:
            return ["sudo", "-u", username]

sudo is required here.

Can you file a bug against happy and put a TODO linking to it in CHIP ?

Actually, I still don't think this is required. Looks like that function will not be run if we're already root.

[mspang]

• Happy tests can be invoked by RUN_HAPPY_TESTS=1 scripts/tests/gn_tests.sh

This doesn't quite work, can you add some documentation before we add these to presubmit?

+ ninja -v -C scripts/tests/../../out/ -k 0 check
ninja: Entering directory `scripts/tests/../../out/'
ninja: error: loading 'build.ninja': No such file or directory

(These GitHub action scripts don't work well locally)

[erjiaqing]

• Happy tests can be invoked by RUN_HAPPY_TESTS=1 scripts/tests/gn_tests.sh

This doesn't quite work, can you add some documentation before we add these to presubmit?

+ ninja -v -C scripts/tests/../../out/ -k 0 check
ninja: Entering directory `scripts/tests/../../out/'
ninja: error: loading 'build.ninja': No such file or directory

(These GitHub action scripts don't work well locally)

Added one more step for gn gen

[mspang]

The flow works reasonably well now and without extraordinary privileges, thank you.

I think we should followup with some further workflow fixes, e.g. it should work in parallel with the rest of the test suite and it should not print output to the console if it passes.

[mspang]

I think we should followup with some further workflow fixes, e.g. it should work in parallel with the rest of the test suite and it should not print output to the console if it passes.

#3214