-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pump device type to chef with only mandatory clusters enabled #26706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Pump device type (0x0303) with only the mandatory clusters enabled: On/Off, Pump Configuration and Control, Identify.
bzbarsky-apple
approved these changes
May 19, 2023
PR #26706: Size comparison from 25a9275 to 1db8b62 Increases (10 builds for bl602, cc32xx, esp32, k32w, telink)
Decreases (11 builds for bl702, efr32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26706: Size comparison from bfa0580 to 015c07a Increases (6 builds for bl702, psoc6, telink)
Decreases (9 builds for efr32, k32w, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26706: Size comparison from bfa0580 to b42f32d Increases (10 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (7 builds for efr32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26706: Size comparison from 853691d to 7aa0fc4 Increases (4 builds for cc32xx, telink)
Decreases (12 builds for bl602, bl702, efr32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
May 23, 2023
- Remove the following clusters from EP0 that aren't specified by the root node device type: Groups, SW Diagnostics, Fixed Label, OTA provider, OTA requestor, Diagnostic Logs, and Switch. - Remove atrributes that are not mandatory - Add attributes that are mandatory - Update cluster revisions and data model revisions
PR #26706: Size comparison from 7b19957 to 5c44214 Increases (2 builds for bl602, bl702)
Decreases (1 build for cc32xx)
Full report (14 builds for bl602, bl702, cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #26706: Size comparison from 75bd5af to 4a5dd4d Increases (3 builds for bl702, nrfconnect)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
PR #26706: Size comparison from 75bd5af to 51c7ce9 Increases (7 builds for bl602, bl702, cc32xx, nrfconnect, psoc6, telink)
Decreases (8 builds for efr32, esp32, psoc6, telink)
Full report (45 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ReneJosefsen
approved these changes
May 24, 2023
ReneJosefsen
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Pump device type (0x0303) with only the mandatory clusters enabled: On/Off, Pump Configuration and Control, Identify.
Testing: