-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial kotlin setuppayload implementation #26676
Merged
andy31415
merged 2 commits into
project-chip:master
from
yufengwangca:pr/java/setup_payload
May 23, 2023
Merged
Add initial kotlin setuppayload implementation #26676
andy31415
merged 2 commits into
project-chip:master
from
yufengwangca:pr/java/setup_payload
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo and
chshu
May 19, 2023 06:55
pullapprove
bot
requested review from
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
May 19, 2023 06:55
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
May 19, 2023 06:55
pullapprove
bot
added
review - pending
examples
controller
and removed
examples
controller
labels
May 19, 2023
PR #26676: Size comparison from e75e729 to 9ac113b Increases (5 builds for cc32xx, k32w, telink)
Decreases (11 builds for bl602, bl702, cyw30739, efr32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/controller/java/src/chip/setuppayload/SetupPayloadParser.kt
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/setuppayload/SetupPayloadParser.kt
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/setuppayload/SetupPayloadParser.kt
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/setuppayload/SetupPayloadParser.kt
Outdated
Show resolved
Hide resolved
PR #26676: Size comparison from b51219b to e427316 Increases (11 builds for bl602, cyw30739, psoc6, telink)
Decreases (8 builds for bl602, bl702, efr32, esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26676: Size comparison from bfa0580 to bb49892 Increases (11 builds for bl602, bl702, psoc6, telink)
Decreases (7 builds for efr32, esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26676: Size comparison from cbd5dac to f7a1f02 Increases (7 builds for bl702, cc32xx, cyw30739, k32w, nrfconnect)
Decreases (3 builds for bl602, psoc6)
Full report (36 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #26676: Size comparison from e217219 to 2d79f97 Increases (12 builds for bl602, bl702, cc32xx, cyw30739, psoc6, qpg, telink)
Decreases (10 builds for efr32, esp32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
joonhaengHeo
approved these changes
May 23, 2023
joonhaengHeo
approved these changes
May 23, 2023
andy31415
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial setuppayload implementation in kotlin, it still rely on the existing native setup_payload implementation, the final goal is to implement setup payload completely in kotlin and deprecate the existing src/setup_payload implemented in java/c++.
Testing:
Leverage the existing CI tests using java_matter_controller