-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove includes of CHIPClusters.h in Darwin code. #26635
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-CHIPClusters-includes
May 17, 2023
Merged
Remove includes of CHIPClusters.h in Darwin code. #26635
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-CHIPClusters-includes
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26635: Size comparison from 21ef744 to 53165e9 Increases (3 builds for bl602, cc32xx, nrfconnect)
Decreases (1 build for bl602)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
Darwin bits don't use CHIPClusters at all anymore.
53165e9
to
313113d
Compare
jtung-apple
approved these changes
May 17, 2023
Fast-tracking platform-specific change with platform owner review. |
andy31415
approved these changes
May 17, 2023
PR #26635: Size comparison from 21ef744 to 313113d Increases (3 builds for nrfconnect, telink)
Decreases (11 builds for bl602, bl702, cyw30739, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darwin bits don't use CHIPClusters anymore.