Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chef]Turn off the Basic Information Reachable attribute #26419

Merged
merged 4 commits into from
May 9, 2023
Merged

[Chef]Turn off the Basic Information Reachable attribute #26419

merged 4 commits into from
May 9, 2023

Conversation

erwinpan1
Copy link
Contributor

Following #26331, Turn off the Basic Information Reachable attribute in Chef devices

@github-actions
Copy link

github-actions bot commented May 8, 2023

PR #26419: Size comparison from f24ab4f to 955fb28

Decreases (1 build for cc32xx)
platform target config section f24ab4f 955fb28 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19609757 19609756 -1 -0.0
Full report (3 builds for cc32xx, qpg)
platform target config section f24ab4f 955fb28 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605090 605090 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957621 957621 0 0.0
.debug_aranges 101136 101136 0 0.0
.debug_frame 341512 341512 0 0.0
.debug_info 19609757 19609756 -1 -0.0
.debug_line 2666632 2666632 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1489225 1489225 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94315 94315 0 0.0
.debug_str 3108982 3108982 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104354 104354 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483384 483384 0 0.0
.symtab 287328 287328 0 0.0
.text 498612 498612 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1167976 1167976 0 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 615076 615076 0 0.0
lock-app qpg6105+debug (read/write) 1137900 1137900 0 0.0
.bss 94816 94816 0 0.0
.data 856 856 0 0.0
.text 585000 585000 0 0.0

@github-actions
Copy link

github-actions bot commented May 8, 2023

PR #26419: Size comparison from 0824a8e to ace6d6b

Decreases (1 build for cc32xx)
platform target config section 0824a8e ace6d6b change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19608262 19608261 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 0824a8e ace6d6b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604962 604962 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957646 957646 0 0.0
.debug_aranges 101040 101040 0 0.0
.debug_frame 341260 341260 0 0.0
.debug_info 19608262 19608261 -1 -0.0
.debug_line 2666227 2666227 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488956 1488956 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94243 94243 0 0.0
.debug_str 3108675 3108675 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483077 483077 0 0.0
.symtab 287168 287168 0 0.0
.text 498524 498524 0 0.0

andy31415
andy31415 requested changes May 8, 2023
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds exceptions to the linter. This seems incorrect and should be explained.

If there are bugs, ideally we should fix the linter and not allow potentially invalid matter files.

@github-actions
Copy link

github-actions bot commented May 8, 2023

PR #26419: Size comparison from 0824a8e to e0de37e

Full report (1 build for cc32xx)
platform target config section 0824a8e e0de37e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604962 604962 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957646 957646 0 0.0
.debug_aranges 101040 101040 0 0.0
.debug_frame 341260 341260 0 0.0
.debug_info 19608262 19608262 0 0.0
.debug_line 2666227 2666227 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488956 1488956 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94243 94243 0 0.0
.debug_str 3108675 3108675 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483077 483077 0 0.0
.symtab 287168 287168 0 0.0
.text 498524 498524 0 0.0

@github-actions
Copy link

github-actions bot commented May 8, 2023

PR #26419: Size comparison from 94f8c34 to 59e16af

Full report (1 build for cc32xx)
platform target config section 94f8c34 59e16af change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604970 604970 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957619 957619 0 0.0
.debug_aranges 101032 101032 0 0.0
.debug_frame 341244 341244 0 0.0
.debug_info 19608094 19608094 0 0.0
.debug_line 2666175 2666175 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1488806 1488806 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94237 94237 0 0.0
.debug_str 3108637 3108637 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104314 104314 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483089 483089 0 0.0
.symtab 287200 287200 0 0.0
.text 498532 498532 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bzbarsky-apple bzbarsky-apple merged commit e5eb60d into project-chip:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erwinpan1 @andy31415 @bzbarsky-apple