Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commission deadlock when discover failed #26417

Closed
wants to merge 2 commits into from
Closed

Commission deadlock when discover failed #26417

wants to merge 2 commits into from

Conversation

tianfeng-yang
Copy link
Contributor

Fixes #26041

@CLAassistant
Copy link

CLAassistant commented May 8, 2023

CLA assistant check
All committers have signed the CLA.

@tianfeng-yang tianfeng-yang changed the title Commission deadlock when discover failed #26041 Commission deadlock when discover failed May 8, 2023

if (self->mPairingDelegate != nullptr)
{
self->mPairingDelegate(err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to compile. Was this tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, I tested locally, I committed the wrong branch code. I first withdraw the request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (self->mPairingDelegate)
{
    self->mPairingDelegate->OnPairingComplete(err);
}

@github-actions
Copy link

github-actions bot commented May 8, 2023

PR #26417: Size comparison from 6c0c5ea to e787738

Increases (1 build for cc32xx)
platform target config section 6c0c5ea e787738 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19609755 19609757 2 0.0
Full report (1 build for cc32xx)
platform target config section 6c0c5ea e787738 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605090 605090 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 957621 957621 0 0.0
.debug_aranges 101136 101136 0 0.0
.debug_frame 341512 341512 0 0.0
.debug_info 19609755 19609757 2 0.0
.debug_line 2666632 2666632 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1489225 1489225 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94315 94315 0 0.0
.debug_str 3108982 3108982 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104354 104354 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483384 483384 0 0.0
.symtab 287328 287328 0 0.0
.text 498612 498612 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Platform] [Linux] A deadlock occurs in the commission of the device
3 participants