-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commission deadlock when discover failed #26417
Conversation
|
||
if (self->mPairingDelegate != nullptr) | ||
{ | ||
self->mPairingDelegate(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not going to compile. Was this tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fault, I tested locally, I committed the wrong branch code. I first withdraw the request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (self->mPairingDelegate)
{
self->mPairingDelegate->OnPairingComplete(err);
}
PR #26417: Size comparison from 6c0c5ea to e787738 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Fixes #26041