-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the extension from .cpp to .hpp in the files that aren't compilation targets #26374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26374: Size comparison from de1c64a to 94c9a9a Increases (2 builds for cc32xx, qpg)
Full report (13 builds for bl602, bl702, cc32xx, k32w, linux, mbed, qpg)
|
jmartinez-silabs
approved these changes
May 4, 2023
Damian-Nordic
approved these changes
May 5, 2023
jmartinez-silabs
added a commit
to SiliconLabs/matter
that referenced
this pull request
May 18, 2023
….hpp in the files that aren't compile targets (project-chip#26374) Merge in WMN_TOOLS/matter from cherry-pick/cpp_to_hpp to RC_2.0.0-1.1 Squashed commit of the following: commit 73c01f99de2cb00cad32326f849c2996b7d66881 Author: Sergei Lissianoi <54454955+selissia@users.noreply.github.com> Date: Fri May 5 09:19:52 2023 -0400 Change the extension from .cpp to .hpp in the files that aren't compile targets (project-chip#26374)
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Jun 23, 2023
….hpp in the files that aren't compile targets (project-chip#26374) Merge in WMN_TOOLS/matter from cherry-pick/cpp_to_hpp to RC_2.0.0-1.1 Squashed commit of the following: commit 73c01f99de2cb00cad32326f849c2996b7d66881 Author: Sergei Lissianoi <54454955+selissia@users.noreply.github.com> Date: Fri May 5 09:19:52 2023 -0400 Change the extension from .cpp to .hpp in the files that aren't compile targets (project-chip#26374)
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Jan 29, 2024
….hpp in the files that aren't compile targets (project-chip#26374) Merge in WMN_TOOLS/matter from cherry-pick/cpp_to_hpp to RC_2.0.0-1.1 Squashed commit of the following: commit 73c01f99de2cb00cad32326f849c2996b7d66881 Author: Sergei Lissianoi <54454955+selissia@users.noreply.github.com> Date: Fri May 5 09:19:52 2023 -0400 Change the extension from .cpp to .hpp in the files that aren't compile targets (project-chip#26374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files GenericThreadStackManagerImpl_OpenThread.cpp and GenericThreadStackManagerImpl_FreeRTOS.cpp are not compilation targets, they are used in the #include statements by other .cpp files. Various IDEs and tools are often configured to treat files with .cpp extension as compile targets, such naming creates conflicts. This PR renames the above files to carry the .hpp extension instead of .cpp.