-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Fix linkage and some apps build for the Sparkfun board #26370
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix/sparkfun_linking
May 4, 2023
Merged
[Silabs] Fix linkage and some apps build for the Sparkfun board #26370
bzbarsky-apple
merged 2 commits into
project-chip:master
from
jmartinez-silabs:fix/sparkfun_linking
May 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
requested changes
May 4, 2023
jepenven-silabs
approved these changes
May 4, 2023
PR #26370: Size comparison from 5ff1818 to a147858 Full report (1 build for cc32xx)
|
PR #26370: Size comparison from 5ff1818 to 63663d4 Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #26357
fixes #26356
fixes #26350
Two recently added files from Silabs SDK needed to be linked for that board.
This board has no buttons, so I added some
#ifdef
to the button's usage in certain apps.Removed some include of the buttons header where they were not needed any more thanks to the ongoing silabs platforms abstraction