Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTA][Silabs] Reset the OTARequestor state if the downloaded image is invalid #26230

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

selissia
Copy link
Contributor

@selissia selissia commented Apr 24, 2023

Fixes #26063

If the downloaded OTA Update image is found to be invalid call the OTA Requestor CancelImageUpdate() API to reset its state, otherwise the Requestor remains in the kApplying state.

All platforms should add similar or equivalent logic to their OTAImageProcessorImpl::Apply() implementations if it's not there already.

Tested on Silabs EFR32 platform.

@github-actions
Copy link

PR #26230: Size comparison from 6025455 to 3bee77f

Increases (1 build for cc32xx)
platform target config section 6025455 3bee77f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19489249 19489251 2 0.0
Full report (1 build for cc32xx)
platform target config section 6025455 3bee77f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 601114 601114 0 0.0
(read/write) 204132 204132 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197544 197544 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956756 956756 0 0.0
.debug_aranges 103416 103416 0 0.0
.debug_frame 349704 349704 0 0.0
.debug_info 19489249 19489251 2 0.0
.debug_line 2678035 2678035 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1501882 1501882 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96008 96008 0 0.0
.debug_str 3024877 3024877 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104170 104170 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 477531 477531 0 0.0
.symtab 285936 285936 0 0.0
.text 494824 494824 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [ESP32SOLO] [lighting-app] [OTA] The Applying process may be imperfect.
3 participants