Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] Add Silabs Platform abstraction #26196

Merged
merged 1 commit into from
Apr 24, 2023
Merged

[Silabs] Add Silabs Platform abstraction #26196

merged 1 commit into from
Apr 24, 2023

Conversation

jepenven-silabs
Copy link
Contributor

Add Abstraction of SDK used in our examples

@jepenven-silabs jepenven-silabs force-pushed the silabs_platform_abstraction_led branch from 527b5b2 to 53336ec Compare April 21, 2023 19:21
@github-actions
Copy link

PR #26196: Size comparison from 65f075c to 53336ec

Full report (1 build for cc32xx)
platform target config section 65f075c 53336ec change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20330829 20330829 0 0.0
.debug_line 2687904 2687904 0 0.0
.debug_loc 2838960 2838960 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042335 3042335 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

@jepenven-silabs jepenven-silabs force-pushed the silabs_platform_abstraction_led branch from 53336ec to 1e50589 Compare April 24, 2023 11:16
@github-actions
Copy link

PR #26196: Size comparison from de0dfcf to 1e50589

Increases (1 build for nrfconnect)
platform target config section de0dfcf 1e50589 change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 774224 774228 4 0.0
Decreases (1 build for cc32xx)
platform target config section de0dfcf 1e50589 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20330829 20330828 -1 -0.0
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section de0dfcf 1e50589 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20330829 20330828 -1 -0.0
.debug_line 2687904 2687904 0 0.0
.debug_loc 2838960 2838960 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042335 3042335 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466336 2466336 0 0.0
.bss 215960 215960 0 0.0
.data 5888 5888 0 0.0
.text 1428980 1428980 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173892 1173892 0 0.0
bss 155557 155557 0 0.0
rodata 132740 132740 0 0.0
text 804836 804836 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1119140 1119140 0 0.0
bss 154713 154713 0 0.0
rodata 109556 109556 0 0.0
text 774224 774228 4 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433952 1433952 0 0.0
bss 135297 135297 0 0.0
rodata 228784 228784 0 0.0
text 775788 775788 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1166568 1166568 0 0.0
.bss 99308 99308 0 0.0
.data 856 856 0 0.0
.text 613668 613668 0 0.0
lock-app qpg6105+debug (read/write) 1136688 1136688 0 0.0
.bss 94452 94452 0 0.0
.data 860 860 0 0.0
.text 583784 583784 0 0.0

@jepenven-silabs jepenven-silabs force-pushed the silabs_platform_abstraction_led branch from e346d89 to 2faba3b Compare April 24, 2023 12:00
@github-actions
Copy link

PR #26196: Size comparison from de0dfcf to 2faba3b

Full report (3 builds for mbed, qpg)
platform target config section de0dfcf 2faba3b change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466336 2466336 0 0.0
.bss 215960 215960 0 0.0
.data 5888 5888 0 0.0
.text 1428980 1428980 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1166568 1166568 0 0.0
.bss 99308 99308 0 0.0
.data 856 856 0 0.0
.text 613668 613668 0 0.0
lock-app qpg6105+debug (read/write) 1136688 1136688 0 0.0
.bss 94452 94452 0 0.0
.data 860 860 0 0.0
.text 583784 583784 0 0.0

@jepenven-silabs jepenven-silabs enabled auto-merge (squash) April 24, 2023 13:47
andy31415
andy31415 approved these changes Apr 24, 2023
View reviewed changes
src/platform/silabs/platformAbstraction/GSDK_SPAM.cpp Show resolved Hide resolved
src/platform/silabs/platformAbstraction/GSDK_SPAM.cpp
{
if (led >= SL_SIMPLE_LED_COUNT)
{
return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use false instead of integer for bool value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff does not show it as done....

src/platform/silabs/platformAbstraction/WiseMCU_SPAM.cpp Show resolved Hide resolved
src/platform/silabs/platformAbstraction/WiseMCU_SPAM.cpp
CHIP_ERROR SilabsPlatform::ToggleLed(uint8_t led) override
{
// TODO add range check ?
RSI_Board_LED_Toggle(led) return CHIP_NO_ERROR;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a ; missing here?

@jepenven-silabs jepenven-silabs merged commit 05d79a2 into project-chip:master Apr 24, 2023
@jepenven-silabs jepenven-silabs mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jepenven-silabs @andy31415 @jmartinez-silabs