Fix the "not storing data" mode of ClusterStateCache to actually work. #26187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we were storing no data, we were computing clusterSize to 0 for all clusters in GetSortedFilters, and then we were not adding any DataVersion filters into our requests at all.
The fix is that in "don't store data" mode we still store how big the data would have been, so we can correctly prioritize our DataVersion filters.
Without this fix, the change in
#26181 fails CI. That CI also acts as a test for this functionality, once
#26181 happens.