-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Enabling the scene-cluster #26186
Merged
lpbeliveau-silabs
merged 41 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scene_cluster
May 30, 2023
Merged
[Scenes] Enabling the scene-cluster #26186
lpbeliveau-silabs
merged 41 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scene_cluster
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…instead. Created method to avoid code dupplication on LastConfiguredId update, addressed low hanging fruits in code style and missing checks
…d un necessary config for max transition time
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
… moved transition time add to response to after success
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…er-app to initialize for tests
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
009d73c
to
17de6b8
Compare
PR #26186: Size comparison from 523cf21 to 17de6b8 Increases above 0.2%:
Increases (38 builds for bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (33 builds for bl602, bl702, cc32xx, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the scene cluster as the scenes-server.
All scene commands and attributes access have been tested through Chip tools.
A subsequent PR will add missing callbacks to the scene server from clusters modifying scenable attributes as well as default cluster callbacks to handle EFS.