-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CHIPReadCallbacks.h in java codegen from zap to jinja #25865
Merged
andy31415
merged 11 commits into
project-chip:master
from
andy31415:move_read_callbacks_to_jinja
Apr 5, 2023
Merged
Move CHIPReadCallbacks.h in java codegen from zap to jinja #25865
andy31415
merged 11 commits into
project-chip:master
from
andy31415:move_read_callbacks_to_jinja
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25865: Size comparison from a5e9259 to 8de0816 Increases (6 builds for bl702, cc13x2_26x2, cyw30739, nrfconnect, psoc6, qpg)
Decreases (5 builds for bl602, cc13x2_26x2, cc32xx, psoc6)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #25865: Size comparison from 040c65d to 79f349b Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Mar 29, 2023
PR #25865: Size comparison from 75f8ddf to bae44ab Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
4c07777
to
760397b
Compare
PR #25865: Size comparison from dfc09ab to 760397b Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25865: Size comparison from dfc09ab to 902ad2b Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on zap&jinja interop is hard, shown in the compile errors from #25853
Moving more things to be purely based on the .matter file content. This is expected to make it easier to ensure generated code is consistent and also validate the input data (i.e. we know what we generate).