Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICD] Subscription resumption should respect min interval on startup #25416

Conversation

jtung-apple
Copy link
Contributor

Addresses https://github.com/CHIP-Specifications/chip-test-plans/issues/2445

This adds a delay to resume subscriptions based on the largest min interval of the persisted subscriptions.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25416: Size comparison from e0ce9e0 to 9ef626e

Increases (1 build for cc32xx)
platform target config section e0ce9e0 9ef626e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_aranges 87336 87344 8 0.0
.debug_frame 300024 300040 16 0.0
.debug_info 20262922 20263037 115 0.0
.debug_line 2657815 2657859 44 0.0
.debug_loc 2800026 2800069 43 0.0
.debug_ranges 282240 282248 8 0.0
.debug_str 3023883 3023989 106 0.0
Full report (3 builds for cc32xx, qpg)
platform target config section e0ce9e0 9ef626e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87344 8 0.0
.debug_frame 300024 300040 16 0.0
.debug_info 20262922 20263037 115 0.0
.debug_line 2657815 2657859 44 0.0
.debug_loc 2800026 2800069 43 0.0
.debug_ranges 282240 282248 8 0.0
.debug_str 3023883 3023989 106 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151684 1151684 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598780 598780 0 0.0
lock-app qpg6105+debug (read/write) 1118892 1118892 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565992 565992 0 0.0

@jtung-apple jtung-apple added the icd Intermittently Connected Devices label Mar 1, 2023
@jtung-apple jtung-apple merged commit 4f53be4 into project-chip:master Mar 7, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…roject-chip#25416)

* [ICD] Subscription resumption should respect min interval on startup

* Added documentation for sub resumption wait logic and referenced improvement issue project-chip#25439

* Cancel timer on Shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app icd Intermittently Connected Devices review - approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants