Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Add a command to list the discovered devices over mdns (and ble for darwin) #25374

Merged
merged 1 commit into from
Mar 15, 2023
Merged

[chip-tool] Add a command to list the discovered devices over mdns (and ble for darwin) #25374

merged 1 commit into from
Mar 15, 2023

Conversation

vivien-apple
Copy link
Contributor

Problem

There is no API to list commissionable BLE devices with darwin. This PR adds one and add a chip-tool command for it.

@vivien-apple vivien-apple self-assigned this Feb 28, 2023
@vivien-apple vivien-apple changed the title [chip-tool] Add an API to list the discovered devices over mdns and ble [chip-tool] Add a command to list the discovered devices over mdns (and ble for darwin) Feb 28, 2023
bzbarsky-apple
bzbarsky-apple requested changes Feb 28, 2023
View reviewed changes
examples/chip-tool/BUILD.gn Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.h Outdated Show resolved Hide resolved
src/platform/Darwin/PlatformManagerImpl.h Outdated Show resolved Hide resolved
@pullapprove pullapprove bot requested a review from cliffamzn February 28, 2023 19:21
@vivien-apple vivien-apple force-pushed the SetUpCodePairer_AddDiscoverDevicesAPI branch from 8fa70f1 to 2f42132 Compare March 1, 2023 18:05
@vivien-apple
Copy link
Contributor Author

I have updated the PR. In short there are 2 new methods, StartDiscoverDevices and StopDiscoverDevices.

@vivien-apple vivien-apple marked this pull request as draft March 1, 2023 18:09
@vivien-apple
Copy link
Contributor Author

I am converting that to a draft since I would like to explore removal of nodes before getting that in.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023 •
edited
Loading

PR #25374: Size comparison from e434c6a to 2f42132

Increases (5 builds for bl702, linux, nrfconnect, psoc6, qpg)
platform target config section e434c6a 2f42132 change % change
bl702 lighting-app bl702+rpc .debug_info 45013159 45013160 1 0.0
.text 1030920 1030922 2 0.0
linux chip-tool-ipv6only arm64 (read only) 12138116 12141796 3680 0.0
(read/write) 733448 733736 288 0.0
.data.rel.ro 675552 675816 264 0.0
.got 15376 15400 24 0.2
.rodata 587140 587204 64 0.0
.text 9810356 9813300 2944 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 777400 777404 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22866192 22866193 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1151676 1151684 8 0.0
.text 598772 598780 8 0.0
Decreases (6 builds for bl602, bl702, cc32xx, psoc6)
platform target config section e434c6a 2f42132 change % change
bl602 lighting-app bl602 .text 1026862 1026858 -4 -0.0
bl602+rpc .text 1057796 1057794 -2 -0.0
bl702 lighting-app bl702 .debug_info 40601128 40601127 -1 -0.0
.text 956150 956148 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 2026292 20262922 -2 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27980259 27980258 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 23118160 23118159 -1 -0.0
Full report (27 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section e434c6a 2f42132 change % change
bl602 lighting-app bl602 (read/write) 1350806 1350806 0 0.0
.bss 94690 94690 0 0.0
.data 9744 9744 0 0.0
.text 1026862 1026858 -4 -0.0
bl602+rpc (read/write) 1396254 1396254 0 0.0
.bss 102738 102738 0 0.0
.data 10136 10136 0 0.0
.text 1057796 1057794 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1189075 1189075 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69785 69785 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1551870 1551870 0 0.0
.debug_aranges 134304 134304 0 0.0
.debug_frame 492456 492456 0 0.0
.debug_info 40601128 40601127 -1 -0.0
.debug_line 5278983 5278983 0 0.0
.debug_loc 3418290 3418290 0 0.0
.debug_ranges 372480 372480 0 0.0
.debug_str 3580726 3580726 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107904 107904 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574866 574866 0 0.0
.symtab 173744 173744 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
956150 956148 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1279055 1279055 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77833 77833 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1700065 1700065 0 0.0
.debug_aranges 142544 142544 0 0.0
.debug_frame 520144 520144 0 0.0
.debug_info 45013159 45013160 1 0.0
.debug_line 5677745 5677745 0 0.0
.debug_loc 3614914 3614914 0 0.0
.debug_ranges 396256 396256 0 0.0
.debug_str 3984263 3984263 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122016 122016 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635883 635883 0 0.0
.symtab 192080 192080 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1030920 1030922 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680743 680743 0 0.0
(read/write) 170328 170328 0 0.0
.bss 80764 80764 0 0.0
.data 3352 3352 0 0.0
.rodata 88527 88527 0 0.0
.text 591900 591900 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643887 643887 0 0.0
(read/write) 157432 157432 0 0.0
.bss 79964 79964 0 0.0
.data 3352 3352 0 0.0
.rodata 78399 78399 0 0.0
.text 565168 565168 0 0.0
lock-ftd LP_CC2652R7 (read only) 676991 676991 0 0.0
(read/write) 171448 171448 0 0.0
.bss 78220 78220 0 0.0
.data 3316 3316 0 0.0
.rodata 76711 76711 0 0.0
.text 599800 599800 0 0.0
lock-mtd LP_CC2652R7 (read only) 663739 663739 0 0.0
(read/write) 179956 179956 0 0.0
.bss 73476 73476 0 0.0
.data 3316 3316 0 0.0
.rodata 103523 103523 0 0.0
.text 559736 559736 0 0.0
pump-app LP_CC2652R7 (read only) 690195 690195 0 0.0
(read/write) 158988 158988 0 0.0
.bss 78196 78196 0 0.0
.data 3280 3280 0 0.0
.rodata 91083 91083 0 0.0
.text 598632 598632 0 0.0
pump-controller-app LP_CC2652R7 (read only) 675147 675147 0 0.0
(read/write) 174172 174172 0 0.0
.bss 78332 78332 0 0.0
.data 3304 3304 0 0.0
.rodata 86971 86971 0 0.0
.text 587696 587696 0 0.0
shell LP_CC2652R7 (read only) 672198 672198 0 0.0
(read/write) 180944 180944 0 0.0
.bss 82836 82836 0 0.0
.data 3348 3348 0 0.0
.rodata 85430 85430 0 0.0
.text 586456 586456 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 2026292 20262922 -2 -0.0
.debug_line 2657815 2657815 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 0 0 0 0.0
535412 535412 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586426 586426 0 0.0
.app_xip_area 463316 463316 0 0.0
.bss 65552 65552 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590394 590394 0 0.0
.app_xip_area 461988 461988 0 0.0
.bss 70840 70840 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551654 551654 0 0.0
.app_xip_area 434040 434040 0 0.0
.bss 60096 60096 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12138116 12141796 3680 0.0
(read/write) 733448 733736 288 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675552 675816 264 0.0
.dynamic 560 560 0 0.0
.got 15376 15400 24 0.2
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 587140 587204 64 0.0
.text 9810356 9813300 2944 0.0
thermostat-no-ble arm64 (read only) 2519284 2519284 0 0.0
(read/write) 145208 145208 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77688 77688 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150704 150704 0 0.0
.text 2106272 2106272 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467384 2467384 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430028 1430028 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1167876 1167876 0 0.0
bss 143423 143423 0 0.0
rodata 136352 136352 0 0.0
text 808260 808260 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1372880 1372880 0 0.0
bss 105902 105902 0 0.0
rodata 213740 213740 0 0.0
text 767744 767744 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1112896 1112896 0 0.0
bss 142579 142579 0 0.0
rodata 113196 113196 0 0.0
text 777400 777404 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841000 841000 0 0.0
(read/write) 1761964 1761964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189704 189704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253561 1253561 0 0.0
.debug_aranges 111456 111456 0 0.0
.debug_frame 374624 374624 0 0.0
.debug_info 27980259 27980258 -1 -0.0
.debug_line 3792840 3792840 0 0.0
.debug_loc 3696008 3696008 0 0.0
.debug_ranges 364136 364136 0 0.0
.debug_str 3533116 3533116 0 0.0
.heap 841000 841000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 581588 581588 0 0.0
.symtab 425936 425936 0 0.0
.text 1561232 1561232 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841808 841808 0 0.0
(read/write) 1702164 1702164 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188904 188904 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1238894 1238894 0 0.0
.debug_aranges 110688 110688 0 0.0
.debug_frame 376960 376960 0 0.0
.debug_info 27524723 27524723 0 0.0
.debug_line 3800339 3800339 0 0.0
.debug_loc 3679209 3679209 0 0.0
.debug_ranges 362072 362072 0 0.0
.debug_str 3520238 3520238 0 0.0
.heap 841808 841808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 541297 541297 0 0.0
.symtab 410848 410848 0 0.0
.text 1502240 1502240 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850072 850072 0 0.0
(read/write) 1615876 1615876 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180808 180808 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074249 1074249 0 0.0
.debug_aranges 102896 102896 0 0.0
.debug_frame 347248 347248 0 0.0
.debug_info 22866192 22866193 1 0.0
.debug_line 3353108 3353108 0 0.0
.debug_loc 3354490 3354490 0 0.0
.debug_ranges 320592 320592 0 0.0
.debug_str 3319000 3319000 0 0.0
.heap 850072 850072 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477014 477014 0 0.0
.symtab 378832 378832 0 0.0
.text 1424216 1424216 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845096 845096 0 0.0
(read/write) 1649740 1649740 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185768 185768 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076193 1076193 0 0.0
.debug_aranges 103296 103296 0 0.0
.debug_frame 349008 349008 0 0.0
.debug_info 23118160 23118159 -1 -0.0
.debug_line 3355375 3355375 0 0.0
.debug_loc 3379185 3379185 0 0.0
.debug_ranges 323144 323144 0 0.0
.debug_str 3337811 3337811 0 0.0
.heap 845096 845096 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480738 480738 0 0.0
.symtab 381008 381008 0 0.0
.text 1453104 1453104 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151676 1151684 8 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598772 598780 8 0.0
lock-app qpg6105+debug (read/write) 1118892 1118892 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565992 565992 0 0.0

@vivien-apple vivien-apple force-pushed the SetUpCodePairer_AddDiscoverDevicesAPI branch from 2f42132 to 7a6daea Compare March 2, 2023 18:06
@github-actions github-actions bot added the ble label Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

PR #25374: Size comparison from 2240c70 to 7a6daea

Increases (1 build for cc32xx)
platform target config section 2240c70 7a6daea change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262927 20262928 1 0.0
Full report (1 build for cc32xx)
platform target config section 2240c70 7a6daea change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262927 20262928 1 0.0
.debug_line 2657820 2657820 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

This was referenced Mar 6, 2023
Merged
Merged
Merged
@vivien-apple vivien-apple force-pushed the SetUpCodePairer_AddDiscoverDevicesAPI branch from 7a6daea to e43eb15 Compare March 9, 2023 13:08
@vivien-apple
Copy link
Contributor Author

I think this is in a shape where it can be reviewed. Please ignore the first commit (
[darwin] Race when BleConnection stop is called) which is reviewed separately.

@vivien-apple vivien-apple marked this pull request as ready for review March 9, 2023 13:11
@vivien-apple vivien-apple force-pushed the SetUpCodePairer_AddDiscoverDevicesAPI branch from e43eb15 to 7c6f9c5 Compare March 9, 2023 14:34
@github-actions github-actions bot added linux tizen For Tizen platform labels Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

PR #25374: Size comparison from 82da16f to 7c6f9c5

Increases (1 build for cc32xx)
platform target config section 82da16f 7c6f9c5 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_loc 2802853 2802854 1 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 82da16f 7c6f9c5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267469 20267469 0 0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802854 1 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467664 2467664 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430308 1430308 0 0.0

@vivien-apple vivien-apple force-pushed the SetUpCodePairer_AddDiscoverDevicesAPI branch 3 times, most recently from b310ae9 to c03ab7b Compare March 9, 2023 17:27
@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited
Loading

PR #25374: Size comparison from 4957e21 to c03ab7b

Increases above 0.2%:

platform target config section 4957e21 c03ab7b change % change
linux chip-tool-ipv6only arm64 .bss 34296 34392 96 0.3
.got 15384 15440 56 0.4
Increases (9 builds for bl702, cc32xx, esp32, linux, psoc6)
platform target config section 4957e21 c03ab7b change % change
bl702 lighting-app bl702 .debug_aranges 134592 134600 8 0.0
.debug_frame 493436 493468 32 0.0
.debug_info 40861237 40864254 3017 0.0
.debug_line 5294017 5294249 232 0.0
.debug_loc 3424650 3425024 374 0.0
.debug_ranges 373184 373192 8 0.0
.debug_str 3585256 3585425 169 0.0
.text 958510 958512 2 0.0
bl702+rpc .debug_aranges 142920 142928 8 0.0
.debug_frame 521380 521412 32 0.0
.debug_info 45488096 4549121 3120 0.0
.debug_line 5699360 5699592 232 0.0
.debug_loc 3622665 3623054 389 0.0
.debug_ranges 397184 397192 8 0.0
.debug_str 3989452 3989621 169 0.0
.text 1033852 1033854 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_loc 2802853 2802854 1 0.0
esp32 all-clusters-app m5stack (read only) 1103143 1103147 4 0.0
.flash.text 1097759 1097763 4 0.0
linux chip-tool-ipv6only arm64 (read only) 12164036 12178540 14504 0.1
(read/write) 733448 734664 1216 0.2
.bss 34296 34392 96 0.3
.data.rel.ro 675552 676608 1056 0.2
.got 15384 15440 56 0.4
.rodata 588516 588812 296 0.1
.text 9834884 9846372 11488 0.1
psoc6 all-clusters cy8ckit_062s2_43012 .debug_aranges 111480 111488 8 0.0
.debug_frame 374760 374788 28 0.0
.debug_info 27985266 27988275 3009 0.0
.debug_line 3794865 3795057 192 0.0
.debug_loc 3699842 3700287 445 0.0
.debug_ranges 364808 364816 8 0.0
.debug_str 3533724 3533875 151 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_aranges 110712 110720 8 0.0
.debug_frame 377096 377124 28 0.0
.debug_info 27529731 2753263 2907 0.0
.debug_line 3802364 3802556 192 0.0
.debug_loc 3683043 3683489 446 0.0
.debug_ranges 362744 362752 8 0.0
.debug_str 3520846 3520997 151 0.0
light cy8ckit_062s2_43012 .debug_aranges 102920 102928 8 0.0
.debug_frame 347380 347408 28 0.0
.debug_info 22871199 22874002 2803 0.0
.debug_line 3355092 3355284 192 0.0
.debug_loc 3358232 3358645 413 0.0
.debug_ranges 321304 321312 8 0.0
.debug_str 3319617 3319768 151 0.0
lock cy8ckit_062s2_43012 .debug_aranges 103312 103320 8 0.0
.debug_frame 349088 349116 28 0.0
.debug_info 23122950 23125856 2906 0.0
.debug_line 3357136 3357328 192 0.0
.debug_loc 3381646 3382059 413 0.0
.debug_ranges 323872 323880 8 0.0
.debug_str 3338170 3338321 151 0.0
Decreases (5 builds for cyw30739, efr32, esp32)
platform target config section 4957e21 c03ab7b change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 591866 591858 -8 -0.0
.app_xip_area 463340 463332 -8 -0.0
efr32 lighting-app BRD4187C (read/write) 1013852 1013844 -8 -0.0
.text 838384 838376 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1079940 1079932 -8 -0.0
.text 904240 904232 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1051520 1051518 -2 -0.0
.flash.text 1051520 1051518 -2 -0.0
m5stack (read/write) 502123 502119 -4 -0.0
.flash.rodata 251448 251444 -4 -0.0
Full report (32 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, psoc6, qpg)
platform target config section 4957e21 c03ab7b change % change
bl602 lighting-app bl602 (read/write) 1352006 1352006 0 0.0
.bss 94690 94690 0 0.0
.data 9744 9744 0 0.0
.text 1027960 1027960 0 0.0
bl602+rpc (read/write) 1397190 1397190 0 0.0
.bss 102738 102738 0 0.0
.data 10136 10136 0 0.0
.text 1058636 1058636 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1191787 1191787 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69793 69793 0 0.0
.bss_psram 30160 30160 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1556816 1556816 0 0.0
.debug_aranges 134592 134600 8 0.0
.debug_frame 493436 493468 32 0.0
.debug_info 40861237 40864254 3017 0.0
.debug_line 5294017 5294249 232 0.0
.debug_loc 3424650 3425024 374 0.0
.debug_ranges 373184 373192 8 0.0
.debug_str 3585256 3585425 169 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 108160 108160 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 576349 576349 0 0.0
.symtab 174160 174160 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
958510 958512 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1282455 1282455 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77841 77841 0 0.0
.bss_psram 30432 30432 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1708931 1708931 0 0.0
.debug_aranges 142920 142928 8 0.0
.debug_frame 521380 521412 32 0.0
.debug_info 45488096 4549121 3120 0.0
.debug_line 5699360 5699592 232 0.0
.debug_loc 3622665 3623054 389 0.0
.debug_ranges 397184 397192 8 0.0
.debug_str 3989452 3989621 169 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122368 122368 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 637674 637674 0 0.0
.symtab 192656 192656 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1033852 1033854 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 681303 681303 0 0.0
(read/write) 169792 169792 0 0.0
.bss 80788 80788 0 0.0
.data 3352 3352 0 0.0
.rodata 88527 88527 0 0.0
.text 592460 592460 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644575 644575 0 0.0
(read/write) 157456 157456 0 0.0
.bss 79988 79988 0 0.0
.data 3352 3352 0 0.0
.rodata 78399 78399 0 0.0
.text 565856 565856 0 0.0
lock-ftd LP_CC2652R7 (read only) 678375 678375 0 0.0
(read/write) 170184 170184 0 0.0
.bss 78340 78340 0 0.0
.data 3316 3316 0 0.0
.rodata 76711 76711 0 0.0
.text 601184 601184 0 0.0
lock-mtd LP_CC2652R7 (read only) 664371 664371 0 0.0
(read/write) 179348 179348 0 0.0
.bss 73500 73500 0 0.0
.data 3316 3316 0 0.0
.rodata 103523 103523 0 0.0
.text 560368 560368 0 0.0
pump-app LP_CC2652R7 (read only) 691611 691611 0 0.0
(read/write) 157692 157692 0 0.0
.bss 78316 78316 0 0.0
.data 3280 3280 0 0.0
.rodata 91083 91083 0 0.0
.text 600048 600048 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676563 676563 0 0.0
(read/write) 172876 172876 0 0.0
.bss 78452 78452 0 0.0
.data 3304 3304 0 0.0
.rodata 86971 86971 0 0.0
.text 589112 589112 0 0.0
shell LP_CC2652R7 (read only) 672742 672742 0 0.0
(read/write) 180424 180424 0 0.0
.bss 82860 82860 0 0.0
.data 3348 3348 0 0.0
.rodata 85430 85430 0 0.0
.text 587000 587000 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267473 20267473 0 0.0
.debug_line 2659773 2659773 0 0.0
.debug_loc 2802853 2802854 1 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 0 0 0 0.0
536372 536372 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587730 587730 0 0.0
.app_xip_area 464500 464500 0 0.0
.bss 65672 65672 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591866 591858 -8 -0.0
.app_xip_area 463340 463332 -8 -0.0
.bss 70960 70960 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 552254 552254 0 0.0
.app_xip_area 434616 434616 0 0.0
.bss 60120 60120 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1031012 1031012 0 0.0
.bss 179276 179276 0 0.0
.data 2060 2060 0 0.0
.text 849656 849656 0 0.0
BRD4187C (read/write) 1013852 1013844 -8 -0.0
.bss 148176 148176 0 0.0
.data 2696 2696 0 0.0
.text 838384 838376 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1079940 1079932 -8 -0.0
.bss 173612 173612 0 0.0
.data 2068 2068 0 0.0
.text 904240 904232 -8 -0.0
window-app BRD4187C (read/write) 1130524 1130524 0 0.0
.bss 132600 132600 0 0.0
.data 2588 2588 0 0.0
.text 970740 970740 0 0.0
esp32 all-clusters-app c3devkit (read only) 1051520 1051518 -2 -0.0
(read/write) 1586058 1586058 0 0.0
.dram0.bss 77824 77824 0 0.0
.dram0.data 13752 13752 0 0.0
.flash.rodata 222720 222720 0 0.0
.flash.text 1051520 1051518 -2 -0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1103143 1103147 4 0.0
(read/write) 502123 502119 -4 -0.0
.dram0.bss 82864 82864 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 251448 251444 -4 -0.0
.flash.text 1097759 1097763 4 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 673704 673704 0 0.0
.bss 65372 65372 0 0.0
.data 2224 2224 0 0.0
.text 574708 574708 0 0.0
light k32w0+release (read/write) 672732 672732 0 0.0
.bss 65036 65036 0 0.0
.data 2212 2212 0 0.0
.text 574084 574084 0 0.0
lock k32w0+release (read/write) 627164 627164 0 0.0
.bss 63108 63108 0 0.0
.data 2136 2136 0 0.0
.text 546904 546904 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12164036 12178540 14504 0.1
(read/write) 733448 734664 1216 0.2
.bss 34296 34392 96 0.3
.data 3008 3008 0 0.0
.data.rel.ro 675552 676608 1056 0.2
.dynamic 560 560 0 0.0
.got 15384 15440 56 0.4
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 588516 588812 296 0.1
.text 9834884 9846372 11488 0.1
thermostat-no-ble arm64 (read only) 2522036 2522036 0 0.0
(read/write) 145256 145256 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77712 77712 0 0.0
.dynamic 560 560 0 0.0
.got 5368 5368 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150960 150960 0 0.0
.text 2108640 2108640 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841000 841000 0 0.0
(read/write) 1762924 1762924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189704 189704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253642 1253642 0 0.0
.debug_aranges 111480 111488 8 0.0
.debug_frame 374760 374788 28 0.0
.debug_info 27985266 27988275 3009 0.0
.debug_line 3794865 3795057 192 0.0
.debug_loc 3699842 3700287 445 0.0
.debug_ranges 364808 364816 8 0.0
.debug_str 3533724 3533875 151 0.0
.heap 841000 841000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 581819 581819 0 0.0
.symtab 426112 426112 0 0.0
.text 0 0 0 0.0
1562192 1562192 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841808 841808 0 0.0
(read/write) 1703220 1703220 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188904 188904 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1238975 1238975 0 0.0
.debug_aranges 110712 110720 8 0.0
.debug_frame 377096 377124 28 0.0
.debug_info 27529731 2753263 2907 0.0
.debug_line 3802364 3802556 192 0.0
.debug_loc 3683043 3683489 446 0.0
.debug_ranges 362744 362752 8 0.0
.debug_str 3520846 3520997 151 0.0
.heap 841808 841808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 541411 541411 0 0.0
.symtab 410960 410960 0 0.0
.text 1503296 1503296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850072 850072 0 0.0
(read/write) 1616860 1616860 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180808 180808 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074312 1074312 0 0.0
.debug_aranges 102920 102928 8 0.0
.debug_frame 347380 347408 28 0.0
.debug_info 22871199 22874002 2803 0.0
.debug_line 3355092 3355284 192 0.0
.debug_loc 3358232 3358645 413 0.0
.debug_ranges 321304 321312 8 0.0
.debug_str 3319617 3319768 151 0.0
.heap 850072 850072 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477245 477245 0 0.0
.symtab 379008 379008 0 0.0
.text 1425200 1425200 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 822296 822296 0 0.0
(read/write) 1673604 1673604 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208568 208568 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076276 1076276 0 0.0
.debug_aranges 103312 103320 8 0.0
.debug_frame 349088 349116 28 0.0
.debug_info 23122950 23125856 2906 0.0
.debug_line 3357136 3357328 192 0.0
.debug_loc 3381646 3382059 413 0.0
.debug_ranges 323872 323880 8 0.0
.debug_str 3338170 3338321 151 0.0
.heap 822296 822296 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480942 480942 0 0.0
.symtab 381152 381152 0 0.0
.text 1454168 1454168 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153020 1153020 0 0.0
.bss 99916 99916 0 0.0
.data 852 852 0 0.0
.text 600116 600116 0 0.0
lock-app qpg6105+debug (read/write) 1119524 1119524 0 0.0
.bss 96308 96308 0 0.0
.data 864 864 0 0.0
.text 566624 566624 0 0.0

@vivien-apple vivien-apple force-pushed the SetUpCodePairer_AddDiscoverDevicesAPI branch from c03ab7b to 8bdc7cc Compare March 10, 2023 08:52
@github-actions
Copy link

PR #25374: Size comparison from bdee2ef to 8bdc7cc

Decreases (1 build for cc32xx)
platform target config section bdee2ef 8bdc7cc change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_loc 2804674 2804673 -1 -0.0
Full report (1 build for cc32xx)
platform target config section bdee2ef 8bdc7cc change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644945 644945 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87376 87376 0 0.0
.debug_frame 300236 300236 0 0.0
.debug_info 20275029 20275029 0 0.0
.debug_line 2660914 2660914 0 0.0
.debug_loc 2804674 2804673 -1 -0.0
.debug_ranges 283248 283248 0 0.0
.debug_str 3026077 3026077 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105921 105921 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379152 379152 0 0.0
.symtab 256848 256848 0 0.0
.text 536904 536904 0 0.0

@woody-apple woody-apple merged commit 346a817 into project-chip:master Mar 15, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
[SetUpCodePairer] Add an API to list the discovered devices if any (p…
9c0c849 
…roject-chip#25374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq arkq is a code owner

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

Assignees

@vivien-apple vivien-apple

Labels
ble controller darwin examples linux platform review - pending tizen For Tizen platform tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @bzbarsky-apple @woody-apple