Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wconversion in src/platform/Darwin. #25323

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Enable -Wconversion in src/platform/Darwin. #25323

merged 1 commit into from
Feb 28, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Also fixes incorrect handling of the bssid from CWNetwork.

@bzbarsky-apple
Copy link
Contributor Author

This may need #25324 to merge before it will compile...

@github-actions
Copy link

PR #25323: Size comparison from 265d55c to 54bfc01

Increases (2 builds for cc32xx, nrfconnect)
platform target config section 265d55c 54bfc01 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20256906 20256908 2 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 767552 767556 4 0.0
Decreases (1 build for qpg)
platform target config section 265d55c 54bfc01 change % change
qpg lock-app qpg6105+debug (read/write) 1118540 1118532 -8 -0.0
.text 565640 565632 -8 -0.0
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section 265d55c 54bfc01 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256906 20256908 2 0.0
.debug_line 2656086 2656086 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023369 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467168 2467168 0 0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429812 1429812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1167432 1167432 0 0.0
bss 143423 143423 0 0.0
rodata 136196 136196 0 0.0
text 807976 807976 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1112452 1112452 0 0.0
bss 142579 142579 0 0.0
rodata 113040 113040 0 0.0
text 777120 777120 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1372532 1372532 0 0.0
bss 105886 105886 0 0.0
rodata 213584 213584 0 0.0
text 767552 767556 4 0.0
qpg lighting-app qpg6105+debug (read/write) 1151340 1151340 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598436 598436 0 0.0
lock-app qpg6105+debug (read/write) 1118540 1118532 -8 -0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565640 565632 -8 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the darwin-platform-Wconversion branch from 54bfc01 to 4d3030d Compare February 25, 2023 05:02
@github-actions
Copy link

PR #25323: Size comparison from b89e83b to 4d3030d

Increases (1 build for cc32xx)
platform target config section b89e83b 4d3030d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20256037 20256038 1 0.0
Decreases (1 build for qpg)
platform target config section b89e83b 4d3030d change % change
qpg lighting-app qpg6105+debug (read/write) 1151292 1151284 -8 -0.0
.text 598388 598380 -8 -0.0
Full report (3 builds for cc32xx, qpg)
platform target config section b89e83b 4d3030d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642609 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256037 20256038 1 0.0
.debug_line 2655900 2655900 0 0.0
.debug_loc 2797195 2797195 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023188 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534724 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151292 1151284 -8 -0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598388 598380 -8 -0.0
lock-app qpg6105+debug (read/write) 1118500 1118500 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565600 565600 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the darwin-platform-Wconversion branch from 4d3030d to a1581b8 Compare February 27, 2023 15:36
@bzbarsky-apple bzbarsky-apple force-pushed the darwin-platform-Wconversion branch from a1581b8 to aa2988a Compare February 27, 2023 19:10
@github-actions github-actions bot added the app label Feb 27, 2023
@github-actions
Copy link

PR #25323: Size comparison from af511d7 to aa2988a

Increases (1 build for cc32xx)
platform target config section af511d7 aa2988a change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642601 642673 72 0.0
.debug_info 20256131 20256163 32 0.0
.debug_line 2656120 2656122 2 0.0
.rodata 105761 105769 8 0.0
.text 534716 534780 64 0.0
Full report (1 build for cc32xx)
platform target config section af511d7 aa2988a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642601 642673 72 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930126 930126 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299812 299812 0 0.0
.debug_info 20256131 20256163 32 0.0
.debug_line 2656120 2656122 2 0.0
.debug_loc 2797440 2797440 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023104 3023104 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105769 8 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534716 534780 64 0.0

@bzbarsky-apple
Enable -Wconversion in src/platform/Darwin.
ded6ec0 
Also fixes incorrect handling of the bssid from CWNetwork.
@bzbarsky-apple bzbarsky-apple force-pushed the darwin-platform-Wconversion branch from aa2988a to ded6ec0 Compare February 27, 2023 20:45
@github-actions
Copy link

PR #25323: Size comparison from af511d7 to ded6ec0

Increases (4 builds for cc32xx, mbed, qpg)
platform target config section af511d7 ded6ec0 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642601 642673 72 0.0
.debug_info 20256131 20256164 33 0.0
.debug_line 2656120 2656122 2 0.0
.rodata 105761 105769 8 0.0
.text 534716 534780 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2467096 2467168 72 0.0
.text 1429740 1429812 72 0.0
qpg lighting-app qpg6105+debug (read/write) 1151252 1151308 56 0.0
.text 598348 598404 56 0.0
lock-app qpg6105+debug (read/write) 1118452 1118508 56 0.0
.text 565552 565608 56 0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section af511d7 ded6ec0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642601 642673 72 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930126 930126 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299812 299812 0 0.0
.debug_info 20256131 20256164 33 0.0
.debug_line 2656120 2656122 2 0.0
.debug_loc 2797440 2797440 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023104 3023104 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105769 8 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534716 534780 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467096 2467168 72 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1429740 1429812 72 0.0
qpg lighting-app qpg6105+debug (read/write) 1151252 1151308 56 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598348 598404 56 0.0
lock-app qpg6105+debug (read/write) 1118452 1118508 56 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565552 565608 56 0.0

@pullapprove pullapprove bot requested a review from sharadb-amazon February 27, 2023 22:24
@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 28, 2023
Open
@bzbarsky-apple bzbarsky-apple merged commit 92d86d5 into project-chip:master Feb 28, 2023
@bzbarsky-apple bzbarsky-apple deleted the darwin-platform-Wconversion branch February 28, 2023 01:47
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Enable -Wconversion in src/platform/Darwin. (project-chip#25323)
f22173f 
Also fixes incorrect handling of the bssid from CWNetwork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

Assignees
No one assigned
Labels
app darwin platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @msandstedt @yunhanw-google @woody-apple @jtung-apple