-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACL cluster to simulated app. #25265
Merged
woody-apple
merged 1 commit into
project-chip:master
from
krypton36:AddACLToSimulatedApp
Feb 23, 2023
Merged
Add ACL cluster to simulated app. #25265
woody-apple
merged 1 commit into
project-chip:master
from
krypton36:AddACLToSimulatedApp
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #25265: Size comparison from 8501d76 to 4ca5eab Increases (6 builds for bl702, cc13x2_26x2, nrfconnect, telink)
Decreases (6 builds for cc13x2_26x2, cc32xx, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 23, 2023
raju-apple
approved these changes
Feb 23, 2023
4ca5eab
to
322fcff
Compare
PR #25265: Size comparison from ebc08a5 to 322fcff Increases (2 builds for bl702)
Full report (7 builds for bl602, bl702, cc32xx, qpg)
|
@@ -2999,6 +3062,21 @@ endpoint 0 { | |||
callback attribute clusterRevision default = 1; | |||
} | |||
|
|||
server cluster AccessControl { | |||
emits event AccessControlEntryChanged; | |||
emits event AccessControlExtensionChanged; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. This does not support the Extension attribute, so does not in fact emit this event. @krypton36
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled and verified that the cluster was present by doing a read.