Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the logic in writeAttributeWithEndpointID in MTRBaseDevice. #25230

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Simplify the logic in writeAttributeWithEndpointID in MTRBaseDevice. #25230

merged 2 commits into from
Feb 22, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

ksperling-apple
ksperling-apple approved these changes Feb 21, 2023
View reviewed changes
src/darwin/Framework/CHIP/MTRBaseDevice.h Show resolved Hide resolved
src/darwin/Framework/CHIP/MTRBaseDevice.mm Outdated Show resolved Hide resolved
@github-actions
Copy link

PR #25230: Size comparison from e04478c to 5b8af6f

Full report (2 builds for qpg)
platform target config section e04478c 5b8af6f change % change
qpg lighting-app qpg6105+debug (read/write) 1151356 1151356 0 0.0
.bss 99796 99796 0 0.0
.data 852 852 0 0.0
.text 598452 598452 0 0.0
lock-app qpg6105+debug (read/write) 1118356 1118356 0 0.0
.bss 96284 96284 0 0.0
.data 864 864 0 0.0
.text 565456 565456 0 0.0

@github-actions
Copy link

PR #25230: Size comparison from e04478c to 07128a0

Increases (1 build for cc32xx)
platform target config section e04478c 07128a0 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20254060 20254061 1 0.0
Full report (1 build for cc32xx)
platform target config section e04478c 07128a0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254060 20254061 1 0.0
.debug_line 2655143 2655143 0 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017553 3017553 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377610 377610 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0

@bzbarsky-apple @ksperling-apple
Address review comments.
4976dd9 
Co-authored-by: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com>
@bzbarsky-apple bzbarsky-apple force-pushed the darwin-simpler-device-write branch from 07128a0 to 4976dd9 Compare February 21, 2023 23:16
@github-actions
Copy link

PR #25230: Size comparison from 30188f5 to 4976dd9

Full report (1 build for cc32xx)
platform target config section 30188f5 4976dd9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254059 20254059 0 0.0
.debug_line 2655143 2655143 0 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017876 3017876 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377610 377610 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0

@yufengwangca yufengwangca merged commit cad990f into project-chip:master Feb 22, 2023
@bzbarsky-apple bzbarsky-apple deleted the darwin-simpler-device-write branch February 22, 2023 02:54
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple @ksperling-apple
Simplify the logic in writeAttributeWithEndpointID in MTRBaseDevice. (p…
d2db8dc 
…roject-chip#25230)

* Simplify the logic in writeAttributeWithEndpointID in MTRBaseDevice.

* Address review comments.

Co-authored-by: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com>

---------

Co-authored-by: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@ksperling-apple ksperling-apple ksperling-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @ksperling-apple @yufengwangca