Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Use mbedtls_pkcs5_pbkdf2_hmac_ext if MBEDTLS_DEPRECATED_REMOVED is defined #25213

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Feb 21, 2023

mbedtls_pkcs5_pbkdf2_hmac is deprecated in mbedtls. If MBEDTLS_DEPRECATED_REMOVED is defined, we should use mbedtls_pkcs5_pbkdf2_hmac_ext instead.

@github-actions
Copy link

PR #25213: Size comparison from e64736c to aebb704

Increases (1 build for cc32xx)
platform target config section e64736c aebb704 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2655143 2655149 6 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section e64736c aebb704 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254060 20254060 0 0.0
.debug_line 2655143 2655149 6 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017470 3017470 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377598 377598 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466784 2466784 0 0.0
.bss 215780 215780 0 0.0
.data 5880 5880 0 0.0
.text 1429428 1429428 0 0.0

@dhrishi
Copy link
Contributor

dhrishi commented Feb 22, 2023

@wqx6 Fixes #24604 ?

@wqx6
Copy link
Contributor Author

wqx6 commented Feb 22, 2023

@wqx6 Fixes #24604 ?

Yes.

@andy31415 andy31415 merged commit e6211d5 into project-chip:master Feb 22, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…ED is defined (project-chip#25213)

* crypto: Use mbedtls_pkcs5_pbkdf2_hmac_ext if MBEDTLS_DEPRECATED_REMOVED is defined

* add mbedtls version check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants