Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backwards error check when storing reboot reason. #25154

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix backwards error check when storing reboot reason. #25154

merged 1 commit into from
Feb 17, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 17, 2023
Merged
@github-actions
Copy link

github-actions bot commented Feb 17, 2023 •
edited
Loading

PR #25154: Size comparison from 336f1c5 to 76fc1e9

Increases (7 builds for bl602, cc13x2_26x2, mbed, psoc6, qpg, telink)
platform target config section 336f1c5 76fc1e9 change % change
bl602 lighting-app bl602 .text 1025420 1025422 2 0.0
cc13x2_26x2 shell LP_CC2652R7 (read only) 671270 671278 8 0.0
.text 585888 585896 8 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2466608 2466672 64 0.0
.text 1429252 1429316 64 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 28093957 28093958 1 0.0
lock cy8ckit_062s2_43012 .debug_info 23226032 23226033 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1150740 1150748 8 0.0
.text 597836 597844 8 0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 951528 951536 8 0.0
text 648388 648390 2 0.0
Decreases (6 builds for bl602, cc13x2_26x2, esp32, telink)
platform target config section 336f1c5 76fc1e9 change % change
bl602 lighting-app bl602+rpc .text 1056356 1056354 -2 -0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 181984 181976 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1049928 1049924 -4 -0.0
.flash.text 1049928 1049924 -4 -0.0
telink lighting-app tlsr9518adk80d text 659106 659104 -2 -0.0
ota-requestor-app tlsr9518adk80d text 602888 602886 -2 -0.0
thermostat tlsr9518adk80d text 594464 594462 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
platform target config section 336f1c5 76fc1e9 change % change
bl602 lighting-app bl602 (read/write) 1349138 1349138 0 0.0
.bss 94786 94786 0 0.0
.data 9736 9736 0 0.0
.text 1025420 1025422 2 0.0
bl602+rpc (read/write) 1394562 1394562 0 0.0
.bss 102834 102834 0 0.0
.data 10128 10128 0 0.0
.text 1056356 1056354 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1187699 1187699 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69889 69889 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4064 4064 0 0.0
.debug_abbrev 1556622 1556622 0 0.0
.debug_aranges 134464 134464 0 0.0
.debug_frame 492812 492812 0 0.0
.debug_info 40714270 40714270 0 0.0
.debug_line 5285903 5285903 0 0.0
.debug_loc 3418025 3418025 0 0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3578290 3578290 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107568 107568 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574175 574175 0 0.0
.symtab 173632 173632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955020 955020 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1280847 1280847 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77937 77937 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1704868 1704868 0 0.0
.debug_aranges 142704 142704 0 0.0
.debug_frame 520576 520576 0 0.0
.debug_info 45129696 45129696 0 0.0
.debug_line 5684946 5684946 0 0.0
.debug_loc 3614981 3614981 0 0.0
.debug_ranges 395968 395968 0 0.0
.debug_str 3981827 3981827 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122208 122208 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635239 635239 0 0.0
.symtab 192096 192096 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1032430 1032430 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679975 679975 0 0.0
(read/write) 171208 171208 0 0.0
.bss 80876 80876 0 0.0
.data 3388 3388 0 0.0
.rodata 88319 88319 0 0.0
.text 591340 591340 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643287 643287 0 0.0
(read/write) 157588 157588 0 0.0
.bss 80084 80084 0 0.0
.data 3388 3388 0 0.0
.rodata 78231 78231 0 0.0
.text 564736 564736 0 0.0
lock-ftd LP_CC2652R7 (read only) 676567 676567 0 0.0
(read/write) 171984 171984 0 0.0
.bss 78332 78332 0 0.0
.data 3316 3316 0 0.0
.rodata 76679 76679 0 0.0
.text 599408 599408 0 0.0
lock-mtd LP_CC2652R7 (read only) 663059 663059 0 0.0
(read/write) 180748 180748 0 0.0
.bss 73588 73588 0 0.0
.data 3316 3316 0 0.0
.rodata 103299 103299 0 0.0
.text 559280 559280 0 0.0
pump-app LP_CC2652R7 (read only) 689507 689507 0 0.0
(read/write) 159764 159764 0 0.0
.bss 78284 78284 0 0.0
.data 3280 3280 0 0.0
.rodata 90931 90931 0 0.0
.text 598096 598096 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674683 674683 0 0.0
(read/write) 174716 174716 0 0.0
.bss 78412 78412 0 0.0
.data 3304 3304 0 0.0
.rodata 86931 86931 0 0.0
.text 587272 587272 0 0.0
shell LP_CC2652R7 (read only) 671270 671278 8 0.0
(read/write) 181984 181976 -8 -0.0
.bss 82948 82948 0 0.0
.data 3384 3384 0 0.0
.rodata 85070 85070 0 0.0
.text 585888 585896 8 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 642473 642473 0 0.0
(read/write) 203784 203784 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197184 197184 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934705 934705 0 0.0
.debug_aranges 87536 87536 0 0.0
.debug_frame 300464 300464 0 0.0
.debug_info 20372652 20372652 0 0.0
.debug_line 2662284 2662284 0 0.0
.debug_loc 2797012 2797012 0 0.0
.debug_ranges 281936 281936 0 0.0
.debug_str 3021415 3021415 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377819 377819 0 0.0
.symtab 256352 256352 0 0.0
.text 0 0 0 0.0
534648 534648 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586282 586282 0 0.0
.app_xip_area 463068 463068 0 0.0
.bss 65656 65656 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590282 590282 0 0.0
.app_xip_area 461764 461764 0 0.0
.bss 70952 70952 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551182 551182 0 0.0
.app_xip_area 433472 433472 0 0.0
.bss 60192 60192 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1040892 1040892 0 0.0
.bss 181584 181584 0 0.0
.data 2048 2048 0 0.0
.text 857240 857240 0 0.0
BRD4187C (read/write) 1137696 1137696 0 0.0
.bss 133272 133272 0 0.0
.data 2536 2536 0 0.0
.text 977292 977292 0 0.0
lock-app BRD4161A+wf200 (read/write) 1067804 1067804 0 0.0
.bss 153104 153104 0 0.0
.data 2056 2056 0 0.0
.text 912624 912624 0 0.0
window-app BRD4187C (read/write) 1138680 1138680 0 0.0
.bss 134856 134856 0 0.0
.data 2576 2576 0 0.0
.text 976652 976652 0 0.0
esp32 all-clusters-app c3devkit (read only) 1049928 1049924 -4 -0.0
(read/write) 1585250 1585250 0 0.0
.dram0.bss 77920 77920 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 221784 221784 0 0.0
.flash.text 1049928 1049924 -4 -0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1101647 1101647 0 0.0
(read/write) 501347 501347 0 0.0
.dram0.bss 82968 82968 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 250528 250528 0 0.0
.flash.text 1096263 1096263 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 670048 670048 0 0.0
.bss 77636 77636 0 0.0
.data 2204 2204 0 0.0
.text 571096 571096 0 0.0
light k32w0+release (read/write) 669084 669084 0 0.0
.bss 77340 77340 0 0.0
.data 2192 2192 0 0.0
.text 570440 570440 0 0.0
lock k32w0+release (read/write) 625952 625952 0 0.0
.bss 75476 75476 0 0.0
.data 2136 2136 0 0.0
.text 545612 545612 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12053252 12053252 0 0.0
(read/write) 729368 729368 0 0.0
.bss 34264 34264 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671552 671552 0 0.0
.dynamic 560 560 0 0.0
.got 15344 15344 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585396 585396 0 0.0
.text 9737252 9737252 0 0.0
thermostat-no-ble arm64 (read only) 2516668 2516668 0 0.0
(read/write) 145240 145240 0 0.0
.bss 56440 56440 0 0.0
.data 1832 1832 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5352 5352 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151320 151320 0 0.0
.text 2103152 2103152 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466608 2466672 64 0.0
.bss 215900 215900 0 0.0
.data 5880 5880 0 0.0
.text 1429252 1429316 64 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840856 840856 0 0.0
(read/write) 1760676 1760676 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189816 189816 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1258168 1258168 0 0.0
.debug_aranges 111584 111584 0 0.0
.debug_frame 374860 374860 0 0.0
.debug_info 28093957 28093958 1 0.0
.debug_line 3798024 3798024 0 0.0
.debug_loc 3691968 3691968 0 0.0
.debug_ranges 363656 363656 0 0.0
.debug_str 3530505 3530505 0 0.0
.heap 840856 840856 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 580880 580880 0 0.0
.symtab 425488 425488 0 0.0
.text 1559800 1559800 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841664 841664 0 0.0
(read/write) 1701180 1701180 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189008 189008 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1243713 1243713 0 0.0
.debug_aranges 110848 110848 0 0.0
.debug_frame 377296 377296 0 0.0
.debug_info 27640053 27640053 0 0.0
.debug_line 3806532 3806532 0 0.0
.debug_loc 3675583 3675583 0 0.0
.debug_ranges 361624 361624 0 0.0
.debug_str 3517768 3517768 0 0.0
.heap 841664 841664 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 540297 540297 0 0.0
.symtab 410496 410496 0 0.0
.text 1501112 1501112 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849984 849984 0 0.0
(read/write) 1614668 1614668 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180896 180896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1078792 1078792 0 0.0
.debug_aranges 103048 103048 0 0.0
.debug_frame 347536 347536 0 0.0
.debug_info 22977085 22977085 0 0.0
.debug_line 3357877 3357877 0 0.0
.debug_loc 3351717 3351717 0 0.0
.debug_ranges 320160 320160 0 0.0
.debug_str 3316856 3316856 0 0.0
.heap 849984 849984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476127 476127 0 0.0
.symtab 378336 378336 0 0.0
.text 1422920 1422920 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845000 845000 0 0.0
(read/write) 1648836 1648836 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185864 185864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1080798 1080798 0 0.0
.debug_aranges 103496 103496 0 0.0
.debug_frame 349444 349444 0 0.0
.debug_info 23226032 23226033 1 0.0
.debug_line 3360010 3360010 0 0.0
.debug_loc 3376314 3376314 0 0.0
.debug_ranges 322736 322736 0 0.0
.debug_str 3335298 3335298 0 0.0
.heap 845000 845000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480035 480035 0 0.0
.symtab 380800 380800 0 0.0
.text 1452104 1452104 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150740 1150748 8 0.0
.bss 99908 99908 0 0.0
.data 852 852 0 0.0
.text 597836 597844 8 0.0
lock-app qpg6105+debug (read/write) 1118300 1118300 0 0.0
.bss 96404 96404 0 0.0
.data 864 864 0 0.0
.text 565400 565400 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015836 1015836 0 0.0
bss 97876 97876 0 0.0
text 686870 686870 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951528 951536 8 0.0
bss 96928 96928 0 0.0
text 648388 648390 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 856164 856164 0 0.0
bss 89056 89056 0 0.0
text 579034 579034 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871884 871884 0 0.0
bss 89140 89140 0 0.0
text 593040 593040 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949936 949936 0 0.0
bss 97284 97284 0 0.0
text 659106 659104 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883316 883316 0 0.0
bss 90084 90084 0 0.0
text 602888 602886 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875984 875984 0 0.0
bss 90532 90532 0 0.0
text 594464 594462 -2 -0.0

@yufengwangca yufengwangca merged commit 0d65448 into project-chip:master Feb 17, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-backwards-check branch February 17, 2023 21:34
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Fix backwards error check when storing reboot reason. (project-chip#2…
f0dd12b 
…5154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @yufengwangca @Damian-Nordic