Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs][EFR32] Adds fix for TC-DRLK-2.10 for the EFR32MG24 and WF200 combo #25127

Merged
merged 6 commits into from
Feb 22, 2023
Merged

[Silabs][EFR32] Adds fix for TC-DRLK-2.10 for the EFR32MG24 and WF200 combo #25127

merged 6 commits into from
Feb 22, 2023

Conversation

rosahay-silabs
Copy link
Contributor

Adds code to enable MATTER shell for EFR32MG24 and WF200 combination.

@rosahay-silabs rosahay-silabs changed the title Adds code to enable VCOM UART and MATTER shell [Silabs][EFR32] Adds code to enable VCOM UART and MATTER shell Feb 16, 2023
@rosahay-silabs rosahay-silabs force-pushed the feature/enable-matter-shell-EFR32MG24x-WF200 branch from ccaec38 to 29f3d2d Compare February 16, 2023 16:39
@github-actions
Copy link

PR #25127: Size comparison from 8015e42 to c6f74f0

Decreases (2 builds for bl602, cc32xx)
platform target config section 8015e42 c6f74f0 change % change
bl602 lighting-app bl602+rpc .text 1056044 1056042 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20347055 20347053 -2 -0.0
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
platform target config section 8015e42 c6f74f0 change % change
bl602 lighting-app bl602 (read/write) 1349102 1349102 0 0.0
.bss 94834 94834 0 0.0
.data 9736 9736 0 0.0
.text 1025366 1025366 0 0.0
bl602+rpc (read/write) 1394270 1394270 0 0.0
.bss 102882 102882 0 0.0
.data 10128 10128 0 0.0
.text 1056044 1056042 -2 -0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1187451 1187451 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69937 69937 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1552964 1552964 0 0.0
.debug_aranges 134384 134384 0 0.0
.debug_frame 492440 492440 0 0.0
.debug_info 40664853 40664853 0 0.0
.debug_line 5282334 5282334 0 0.0
.debug_loc 3414245 3414245 0 0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3575377 3575377 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107552 107552 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574023 574023 0 0.0
.symtab 173584 173584 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 954764 954764 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1280607 1280607 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77985 77985 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1701454 1701454 0 0.0
.debug_aranges 142616 142616 0 0.0
.debug_frame 520188 520188 0 0.0
.debug_info 45074210 45074210 0 0.0
.debug_line 5681330 5681330 0 0.0
.debug_loc 3611163 3611163 0 0.0
.debug_ranges 395960 395960 0 0.0
.debug_str 3978881 3978881 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122192 122192 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635082 635082 0 0.0
.symtab 192048 192048 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1032160 1032160 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87464 87464 0 0.0
.debug_frame 300232 300232 0 0.0
.debug_info 20347055 20347053 -2 -0.0
.debug_line 2658245 2658245 0 0.0
.debug_loc 2791387 2791387 0 0.0
.debug_ranges 281600 281600 0 0.0
.debug_str 3015122 3015122 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12050772 12050772 0 0.0
(read/write) 729208 729208 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671424 671424 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585300 585300 0 0.0
.text 9735204 9735204 0 0.0
thermostat-no-ble arm64 (read only) 2517204 2517204 0 0.0
(read/write) 145320 145320 0 0.0
.bss 56488 56488 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77544 77544 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151232 151232 0 0.0
.text 2103680 2103680 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150556 1150556 0 0.0
.bss 99932 99932 0 0.0
.data 848 848 0 0.0
.text 597656 597656 0 0.0
lock-app qpg6105+debug (read/write) 1117820 1117820 0 0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 564916 564916 0 0.0

@rosahay-silabs rosahay-silabs force-pushed the feature/enable-matter-shell-EFR32MG24x-WF200 branch from c6f74f0 to 3aed5cf Compare February 17, 2023 04:21
@rosahay-silabs rosahay-silabs changed the title [Silabs][EFR32] Adds code to enable VCOM UART and MATTER shell [Silabs][EFR32] Adds fix for TC-DRLK-2.10 for the EFR32MG24 and WF200 combo Feb 17, 2023
@rosahay-silabs rosahay-silabs force-pushed the feature/enable-matter-shell-EFR32MG24x-WF200 branch 2 times, most recently from 30868d9 to 70c36ac Compare February 17, 2023 14:05
@rosahay-silabs rosahay-silabs marked this pull request as ready for review February 17, 2023 14:19
@rosahay-silabs rosahay-silabs force-pushed the feature/enable-matter-shell-EFR32MG24x-WF200 branch 2 times, most recently from 5984bb1 to c2aa2e6 Compare February 17, 2023 14:25
@github-actions
Copy link

PR #25127: Size comparison from 99821fa to 1cee507

Decreases (1 build for cc32xx)
platform target config section 99821fa 1cee507 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20373023 20373022 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 99821fa 1cee507 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642473 642473 0 0.0
(read/write) 203784 203784 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197184 197184 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934721 934721 0 0.0
.debug_aranges 87544 87544 0 0.0
.debug_frame 300488 300488 0 0.0
.debug_info 20373023 20373022 -1 -0.0
.debug_line 2662433 2662433 0 0.0
.debug_loc 2797119 2797119 0 0.0
.debug_ranges 281944 281944 0 0.0
.debug_str 3021437 3021437 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377819 377819 0 0.0
.symtab 256352 256352 0 0.0
.text 534648 534648 0 0.0

@rosahay-silabs rosahay-silabs force-pushed the feature/enable-matter-shell-EFR32MG24x-WF200 branch from 8ef8482 to 0085565 Compare February 19, 2023 03:15
@github-actions
Copy link

PR #25127: Size comparison from 738205d to 0085565

Full report (1 build for cc32xx)
platform target config section 738205d 0085565 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642217 642217 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360343 20360343 0 0.0
.debug_line 2661062 2661062 0 0.0
.debug_loc 2797107 2797107 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534392 534392 0 0.0

@pullapprove pullapprove bot requested a review from nivi-apple February 20, 2023 20:06
@bzbarsky-apple bzbarsky-apple merged commit 49f6009 into project-chip:master Feb 22, 2023
@rosahay-silabs rosahay-silabs deleted the feature/enable-matter-shell-EFR32MG24x-WF200 branch February 22, 2023 17:01
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@rosahay-silabs @restyled-commits
[Silabs][EFR32] Adds fix for TC-DRLK-2.10 for the EFR32MG24 and WF200…
68d16a7 
… combo (project-chip#25127)

* Adds code to enable VCOM UART and MATTER shell

* Adds fix to omit header file unless needed

* Restyled by whitespace

* Restyled by clang-format

* Adds fix for compilation on BRD4161A

* Incorporate feedback

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

Assignees
No one assigned
Labels
examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rosahay-silabs @bzbarsky-apple @jmartinez-silabs @restyled-commits