-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add the reason of the constraint failure to matter… #25086
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_ConstraintFailureReason
Feb 16, 2023
Merged
[matter_yamltests] Add the reason of the constraint failure to matter… #25086
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_ConstraintFailureReason
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6db4dd
to
64519fc
Compare
PR #25086: Size comparison from d2e4c4a to 64519fc Increases (3 builds for bl602, esp32, psoc6)
Decreases (6 builds for bl702, esp32, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, linux, mbed, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 16, 2023
64519fc
to
5b4f7ef
Compare
PR #25086: Size comparison from 352efee to 5b4f7ef Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
tehampson
reviewed
Feb 16, 2023
…_yamltests/constraints.py
5b4f7ef
to
5bbbed3
Compare
tehampson
approved these changes
Feb 16, 2023
PR #25086: Size comparison from 8015e42 to 5bbbed3 Decreases (3 builds for bl602, bl702, cc32xx)
Full report (16 builds for bl602, bl702, cc13x2_26x2, cc32xx, linux, qpg)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…_yamltests/constraints.py (project-chip#25086)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_yamltests/constraints.py
Problem
When a constraint fails, the
matter_yamltests
package does not gives any explanation why.This PR adds those explanations and re-use the pretty error mechanism to make it looks easy to understand.
For example instead of failing with no particular reason, when it is handled properly it may looks like:
![Screenshot 2023-02-15 at 19 44 28](https://user-images.githubusercontent.com/65897387/219123232-4f9d88f3-e0ef-4ad3-89ad-1ac06317eddd.png)