-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed All Clusters Minimal App ZAP File #25034
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
emargolis:emargolis/feature/fix-all-clusters-minimal-app-events
Feb 15, 2023
Merged
Fixed All Clusters Minimal App ZAP File #25034
yufengwangca
merged 2 commits into
project-chip:master
from
emargolis:emargolis/feature/fix-all-clusters-minimal-app-events
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emargolis
commented
Feb 14, 2023
- Removed all Actions Cluster events, which are currently not implemented in the SDK.
- Removed StateChange event of the Boolean State Cluster, which is not implemented for this app.
- Removed SwitchLatched event of the State Cluster, which is not implemented for this app.
PR #25034: Size comparison from e7528bc to ba814ba Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
approved these changes
Feb 14, 2023
- Removed all Actions Cluster events, which are currently not implemented in the SDK. - Removed StateChange event of the Boolean State Cluster, which is not implemented for this app. - Removed SwitchLatched event of the State Cluster, which is not implemented for this app.
ba814ba
to
25e9085
Compare
yufengwangca
approved these changes
Feb 14, 2023
PR #25034: Size comparison from bd78b86 to 25e9085 Increases (8 builds for bl702, cyw30739, esp32, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Fixed All Clusters Minimal App ZAP File - Removed all Actions Cluster events, which are currently not implemented in the SDK. - Removed StateChange event of the Boolean State Cluster, which is not implemented for this app. - Removed SwitchLatched event of the State Cluster, which is not implemented for this app. * ZAP REGEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.