Add a sample UI for linux apps - lighting app #24979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed linux app shutdown to handle signals by loop terminating instead of app killing.
b4f20dc to
d7fa8c4
Compare
|
PR #24979: Size comparison from 5ad70f6 to fb9c267 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #24979: Size comparison from 5ad70f6 to d840e82 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Feb 10, 2023
|
PR #24979: Size comparison from 5ad70f6 to 9eb3991 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
arkq
approved these changes
Feb 13, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Feb 14, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Feb 14, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Feb 14, 2023
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Feb 14, 2023
vivien-apple
added a commit
that referenced
this pull request
Feb 14, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Initial version of a imgui UI in light app for linux. Also fixed linux app shutdown to handle signals by loop terminating instead of app killing. * remove some fixme comments * Fix unit tests ... with-ui variant was added * Restyle * Update text and remove some commented out code * Restyle --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewing app state during testing on linux is very tedious when using just the console.
Added an example UI that can be optionally compiled for linux apps and enabled it for the light example.
Specifically this does:
adds a 'imgui' submodule for linux. I hard-coded SDL2 + opengl3 for rendering to not do more exec_script at runtime for now. It should mostly compile out of the box if used
optionally enable a
uifor lighting appAdded the following bindings to it:
Fixed linux shutdown bug:
CONTROL + Cwould just cancel the app without doing a chip event loop stop. Updated to add signal handlers to the shared chip main loop app for linux.Ideally I would like to also device state (commissioning, commissioned, fabrics, active sessions etc) however for now adding the bare minimum to have something.