-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove types-silabs.xml #24976
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:RemoveTypesSilabs
Feb 10, 2023
Merged
Remove types-silabs.xml #24976
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:RemoveTypesSilabs
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Feb 10, 2023
PR #24976: Size comparison from 5ad70f6 to eb14060 Increases (12 builds for bl702, cc13x2_26x2, cc32xx, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, efr32, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, psoc6, qpg, telink)
|
andy31415
approved these changes
Feb 10, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Remove types-silabs.xml * Update generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is unclear to me what the last types in
types-silabs.xml
refers to - I tried to get them to match from some ZCL references / Matter specifications but I found nothing that looks related to the Matter spec.So I tempted to just delete those and this PR is an attempt at that.