[matter_yamltests] Add a dedicated class to load the yaml, enforce ty… #24975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09c7233 to
63fe2f4
Compare
|
PR #24975: Size comparison from bbfd5d6 to f781eee Full report (2 builds for cc32xx, mbed)
|
f781eee to
c2fbfd4
Compare
|
PR #24975: Size comparison from bbfd5d6 to c2fbfd4 Increases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (3 builds for cc13x2_26x2, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 13, 2023
tehampson
reviewed
Feb 13, 2023
c2fbfd4 to
4899c6f
Compare
|
PR #24975: Size comparison from 5a23941 to 4899c6f Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
reviewed
Feb 13, 2023
4899c6f to
0825b6c
Compare
0825b6c to
906977f
Compare
|
PR #24975: Size comparison from b04c8ca to 906977f Increases (11 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (2 builds for efr32, linux)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, psoc6, qpg, telink)
|
…pes, validate keywords, and add some implicit rules checking
906977f to
f785701
Compare
|
PR #24975: Size comparison from b3c599d to f785701 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
Fast tracking test enhancements |
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…pes, validate keywords, and add some implicit rules checking (project-chip#24975)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pes, validate keywords, and add some implicit rules checking
Problem
When loading
yamltest files with the python parser, most of the expectations about types of the yaml schema are fine. But this is mostly because it was enforced by the strong type checking that was existing before running dynamically as it was generating code that needs to be compiled.This PR adds a dedicated
YamlLoaderclass with various tests tomatter_yamltests. This class loads a yaml file and check that it is a proper yaml 'test' file.In summary it adds:
nodeIdandgroupIdcan not coexistschip-replwas lying about it working. This is because it does not supports group communication and so it fallbacks on the default path that uses unicast messages and so it effectively able to received a response but that is unexpected.Most of the additional code in this PR comes from the tests, the rest is just adding types to the list of allowed keywords plus the addition of those implicit rules.