Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OnOff GlobalSceneControl incorrect state change #24800

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix OnOff GlobalSceneControl incorrect state change #24800

merged 1 commit into from
Feb 2, 2023

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Feb 1, 2023 •
edited
Loading

This PR Fixes #24638
MoveToLevelWithOnOff should only set the GlobalSceneControl to true if it produced a On action when the on off feature map cluster indicate the lighting feature.

The wrong cluster's featuremap was also verified. The command is from the level cluster but the GlobalSceneControl attributes is enable with to the onoff ligthing featuremap.

Tested using the lighting app on efr32 and the chip-tool tests Test_TC_OO_2_3
[1675282792.995858][398020:398025] CHIP:TOO: **** Test Complete: Test_TC_OO_2_3

@jmartinez-silabs
Fix MoveToLevelWithOnOff to only set the SceneGlobalControl to true i…
145cee7 
…f it produced a On value. Also we were not checking the featuremap of the right cluster
bzbarsky-apple
bzbarsky-apple approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, this makes sense.

@github-actions github-actions bot added the app label Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023 •
edited
Loading

PR #24800: Size comparison from 54b2461 to 145cee7

Increases (20 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, qpg, telink)
platform target config section 54b2461 145cee7 change % change
bl602 lighting-app bl602 .text 1022522 1022524 2 0.0
bl702 lighting-app bl702 .debug_info 40198208 40198266 58 0.0
.debug_line 5266054 5266100 46 0.0
.debug_loc 3400632 3400670 38 0.0
bl702+rpc .debug_info 44594580 44594637 57 0.0
.debug_line 5664522 5664568 46 0.0
.debug_loc 3596881 3596919 38 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 660175 660183 8 0.0
.text 556920 556928 8 0.0
pump-app LP_CC2652R7 (read only) 686883 686899 16 0.0
.text 595968 595984 16 0.0
efr32 lighting-app BRD4187C (read/write) 1150752 1150760 8 0.0
.text 990692 990700 8 0.0
esp32 all-clusters-app c3devkit (read only) 1046602 1046610 8 0.0
.flash.text 1046602 1046610 8 0.0
m5stack (read only) 1098291 1098303 12 0.0
.flash.text 1092907 1092919 12 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 803808 803816 8 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1366012 1366028 16 0.0
text 763564 763572 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 773880 773888 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1755732 1755748 16 0.0
.debug_info 27505607 27505680 73 0.0
.debug_line 3779124 3779184 60 0.0
.debug_loc 3673185 3673227 42 0.0
.text 1554808 1554824 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27063368 27063440 72 0.0
.debug_line 3787499 3787559 60 0.0
.debug_loc 3656916 3656958 42 0.0
light cy8ckit_062s2_43012 .debug_info 22490619 22490691 72 0.0
.debug_line 3340291 3340351 60 0.0
.debug_loc 3336464 3336506 42 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147704 16 0.0
.text 594788 594804 16 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1015272 1015288 16 0.0
text 685416 685428 12 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 951940 951948 8 0.0
text 647800 647808 8 0.0
light-switch-app tlsr9518adk80d text 592902 592904 2 0.0
lighting-app tlsr9518adk80d (read/write) 950484 950492 8 0.0
text 658300 658308 8 0.0
thermostat tlsr9518adk80d text 594480 594482 2 0.0
Decreases (6 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6)
platform target config section 54b2461 145cee7 change % change
bl602 lighting-app bl602+rpc (read/write) 1390682 1390674 -8 -0.0
.text 1053204 1053200 -4 -0.0
bl702 lighting-app bl702+rpc .text 1028588 1028586 -2 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183680 183672 -8 -0.0
pump-app LP_CC2652R7 (read/write) 162444 162428 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583898 583890 -8 -0.0
.app_xip_area 460652 460644 -8 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22711597 22711596 -1 -0.0
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 54b2461 145cee7 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022522 1022524 2 0.0
bl602+rpc (read/write) 1390682 1390674 -8 -0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053204 1053200 -4 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550158 1550158 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490960 490960 0 0.0
.debug_info 40198208 40198266 58 0.0
.debug_line 5266054 5266100 46 0.0
.debug_loc 3400632 3400670 38 0.0
.debug_ranges 371672 371672 0 0.0
.debug_str 3534920 3534920 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951564 951564 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698572 1698572 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518664 518664 0 0.0
.debug_info 44594580 44594637 57 0.0
.debug_line 5664522 5664568 46 0.0
.debug_loc 3596881 3596919 38 0.0
.debug_ranges 395376 395376 0 0.0
.debug_str 3938158 3938158 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028588 1028586 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676771 676771 0 0.0
(read/write) 174476 174476 0 0.0
.bss 80940 80940 0 0.0
.data 3384 3384 0 0.0
.rodata 87515 87515 0 0.0
.text 588940 588940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640851 0 0.0
(read/write) 157632 157632 0 0.0
.bss 80132 80132 0 0.0
.data 3384 3384 0 0.0
.rodata 77467 77467 0 0.0
.text 563064 563064 0 0.0
lock-ftd LP_CC2652R7 (read only) 673823 673823 0 0.0
(read/write) 174768 174768 0 0.0
.bss 78372 78372 0 0.0
.data 3312 3312 0 0.0
.rodata 76311 76311 0 0.0
.text 597032 597032 0 0.0
lock-mtd LP_CC2652R7 (read only) 660175 660183 8 0.0
(read/write) 183680 183672 -8 -0.0
.bss 73636 73636 0 0.0
.data 3312 3312 0 0.0
.rodata 102775 102775 0 0.0
.text 556920 556928 8 0.0
pump-app LP_CC2652R7 (read only) 686883 686899 16 0.0
(read/write) 162444 162428 -16 -0.0
.bss 78340 78340 0 0.0
.data 3276 3276 0 0.0
.rodata 90435 90435 0 0.0
.text 595968 595984 16 0.0
pump-controller-app LP_CC2652R7 (read only) 672315 672315 0 0.0
(read/write) 177124 177124 0 0.0
.bss 78452 78452 0 0.0
.data 3300 3300 0 0.0
.rodata 86515 86515 0 0.0
.text 585320 585320 0 0.0
shell LP_CC2652R7 (read only) 668022 668022 0 0.0
(read/write) 185296 185296 0 0.0
.bss 83012 83012 0 0.0
.data 3380 3380 0 0.0
.rodata 84254 84254 0 0.0
.text 583456 583456 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583898 583890 -8 -0.0
.app_xip_area 460652 460644 -8 -0.0
.bss 65696 65696 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587614 587614 0 0.0
.app_xip_area 459072 459072 0 0.0
.bss 70984 70984 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549358 549358 0 0.0
.app_xip_area 431592 431592 0 0.0
.bss 60256 60256 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1037624 1037624 0 0.0
.bss 181624 181624 0 0.0
.data 2044 2044 0 0.0
.text 853932 853932 0 0.0
BRD4187C (read/write) 1150752 1150760 8 0.0
.bss 132920 132920 0 0.0
.data 2544 2544 0 0.0
.text 990692 990700 8 0.0
lock-app BRD4161A+wf200 (read/write) 1065296 1065296 0 0.0
.bss 153152 153152 0 0.0
.data 2052 2052 0 0.0
.text 910068 910068 0 0.0
window-app BRD4187C (read/write) 1145660 1145660 0 0.0
.bss 134424 134424 0 0.0
.data 2572 2572 0 0.0
.text 984068 984068 0 0.0
esp32 all-clusters-app c3devkit (read only) 1046602 1046610 8 0.0
(read/write) 1518682 1518682 0 0.0
.dram0.bss 78024 78024 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220640 220640 0 0.0
.flash.text 1046602 1046610 8 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1098291 1098303 12 0.0
(read/write) 500303 500303 0 0.0
.dram0.bss 83072 83072 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 249388 249388 0 0.0
.flash.text 1092907 1092919 12 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659452 659452 0 0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561604 561604 0 0.0
light k32w0+release (read/write) 671404 671404 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592204 592204 0 0.0
lock k32w0+release (read/write) 630784 630784 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550796 550796 0 0.0
linux chip-tool-ipv6only arm64 (read only) 11040108 11040108 0 0.0
(read/write) 704904 704904 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648312 648312 0 0.0
.dynamic 560 560 0 0.0
.got 14128 14128 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 577084 577084 0 0.0
.text 8789796 8789796 0 0.0
thermostat-no-ble arm64 (read only) 2506620 2506620 0 0.0
(read/write) 144680 144680 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2093936 2093936 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160672 0 0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803816 8 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366028 16 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763564 763572 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773880 773888 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755732 1755748 16 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251513 1251513 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373628 373628 0 0.0
.debug_info 27505607 27505680 73 0.0
.debug_line 3779124 3779184 60 0.0
.debug_loc 3673185 3673227 42 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485030 3485030 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 1554808 1554824 16 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697612 1697612 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237224 1237224 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376072 376072 0 0.0
.debug_info 27063368 27063440 72 0.0
.debug_line 3787499 3787559 60 0.0
.debug_loc 3656916 3656958 42 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470783 3470783 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497504 1497504 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611180 1611180 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071614 1071614 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346616 346616 0 0.0
.debug_info 22490619 22490691 72 0.0
.debug_line 3340291 3340351 60 0.0
.debug_loc 3336464 3336506 42 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274807 3274807 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419392 1419392 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645188 1645188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073262 1073262 0 0.0
.debug_aranges 103192 103192 0 0.0
.debug_frame 348448 348448 0 0.0
.debug_info 22711597 22711596 -1 -0.0
.debug_line 3341772 3341772 0 0.0
.debug_loc 3357821 3357821 0 0.0
.debug_ranges 321304 321304 0 0.0
.debug_str 3291255 3291255 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477035 477035 0 0.0
.symtab 379504 379504 0 0.0
.text 1448416 1448416 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147704 16 0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594804 16 0.0
lock-app qpg6105+debug (read/write) 1115408 1115408 0 0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562504 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015272 1015288 16 0.0
bss 98044 98044 0 0.0
text 685416 685428 12 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951940 951948 8 0.0
bss 97092 97092 0 0.0
text 647800 647808 8 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857468 857468 0 0.0
bss 89216 89216 0 0.0
text 578856 578856 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873168 873168 0 0.0
bss 89304 89304 0 0.0
text 592902 592904 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950484 950492 8 0.0
bss 97452 97452 0 0.0
text 658300 658308 8 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887336 887336 0 0.0
bss 90252 90252 0 0.0
text 604274 604274 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877376 877376 0 0.0
bss 90692 90692 0 0.0
text 594480 594482 2 0.0

@jmartinez-silabs jmartinez-silabs merged commit 836390e into project-chip:master Feb 2, 2023
@jmartinez-silabs jmartinez-silabs deleted the OO_globalscene branch February 2, 2023 16:58
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@jmartinez-silabs
Fix MoveToLevelWithOnOff to only set the SceneGlobalControl to true i…
1e04b2e 
…f it produced a On value. Also we were not checking the featuremap of the right cluster (project-chip#24800)
Caldwell1988 pushed a commit to Eltako/connectedhomeip that referenced this pull request Aug 7, 2023
@jmartinez-silabs @Caldwell1988
Fix MoveToLevelWithOnOff to only set the SceneGlobalControl to true i…
9fdb17a 
…f it produced a On value. Also we were not checking the featuremap of the right cluster (project-chip#24800)
@Caldwell1988 Caldwell1988 mentioned this pull request Aug 7, 2023
Merged
Caldwell1988 added a commit to Eltako/connectedhomeip that referenced this pull request Aug 7, 2023
@Caldwell1988
Fix MoveToLevelWithOnOff to only set the SceneGlobalControl to true i… (
9712196 
#3)

Patch from project-chip#24800 of connectedhomeip repository:

Original message:
This PR Fixes
project-chip#24638
MoveToLevelWithOnOff should only set the GlobalSceneControl to true if
it produced a On action when the on off feature map cluster indicate the
lighting feature.

The wrong cluster's featuremap was also verified. The command is from
the level cluster but the GlobalSceneControl attributes is enable with
to the onoff ligthing featuremap.

Tested using the lighting app on efr32 and the chip-tool tests
Test_TC_OO_2_3
`[1675282792.995858][398020:398025] CHIP:TOO: **** Test Complete:
Test_TC_OO_2_3`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@lpbeliveau-silabs lpbeliveau-silabs lpbeliveau-silabs approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Test_TC_OO_2_3 failure
3 participants
@jmartinez-silabs @bzbarsky-apple @lpbeliveau-silabs