-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch default generation target for generate.py to matter idl files #24756
Merged
andy31415
merged 15 commits into
project-chip:master
from
andy31415:matter_idl_default_generate
Jan 31, 2023
Merged
Switch default generation target for generate.py to matter idl files #24756
andy31415
merged 15 commits into
project-chip:master
from
andy31415:matter_idl_default_generate
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault that always exists for now)
bzbarsky-apple
approved these changes
Jan 31, 2023
…the checkout filesystem
tehampson
approved these changes
Jan 31, 2023
bzbarsky-apple
approved these changes
Jan 31, 2023
jmartinez-silabs
approved these changes
Jan 31, 2023
kkasperczyk-no
approved these changes
Jan 31, 2023
PR #24756: Size comparison from 210ae33 to e7ab5c9 Increases (8 builds for esp32, linux, psoc6, telink)
Decreases (8 builds for bl602, bl702, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#24756) * Documentation update * Fix paths * No need for an output directory for matter idl generation * Restyle * Make the output directory for generate.py really not needed (use a default that always exists for now) * Simplify the code * Restyle * Update regen_all to be able to figure out distinct commands using dry-run * Use a proper temporary directory, so matter idl naming does not clash * Regen * Fix usage of None for output directory in chef * Update template name for statistics output * Updated template text again to make it clearer what we generate * Fix chef codegen * Use shutil move since on CI the temporary directory is separate from the checkout filesystem --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--dry-run
command can be used to figure out what one wants to run manually