Allowing pregenerated files in python build #24752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR #24752: Size comparison from 210ae33 to a11d780 Increases (2 builds for esp32)
Decreases (10 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 31, 2023
|
PR #24752: Size comparison from 210ae33 to 085c45e Increases (4 builds for esp32, psoc6, telink)
Decreases (12 builds for bl602, bl702, k32w, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 31, 2023
|
@oidebrett Restyle failures? |
Hi, sorry about that. This is my first PR to this repo. I have made the restyling changes as requested and added some extra information on what is being pregenerated. Could I just check if I am doing this PR push correctly? I am following the Contributing guide: https://github.com/oidebrett/connectedhomeip/blob/master/CONTRIBUTING.md#submitting-a-pull-request When I get to final step to "Push and Test" I get an error: When I do a git status the only files that are modified in this branch compared to my master repo branches are the third party submodule files that I guess were brought in when I did a git submodule update --init. e.g. third_party/infineon/psoc6/psoc6_sdk/libs/serial-flash Should I use -f to force this? Whats the best practice Thanks for the advice. I enjoy contributing to this amazing project!! |
No need to apologize!
It depends on how you applied your changes. If you created a new changeset for the changes, then I'm surprised you are getting the errors you are getting, and we should figure out what's actually going on there. Please let me know if that's the case. If you amended your existing changeset, or rebased things, then yes just |
|
@oidebrett Still restyle failures. See https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/2798166/patch for the patch the restyler is suggesting. |
…s per issues - Build Python fails due to Zap Generation on Raspberry Pi (no ARM based version of zap-cli available) #24718
|
PR #24752: Size comparison from 554e871 to aa5a743 Increases (9 builds for bl602, bl702, cyw30739, esp32, telink)
Decreases (5 builds for bl602, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@oidebrett Thank you for the PR! |
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* checking that we can commit * checking that we can commit by deleting file that was added * modified build_python.sh to take argument to use pregenerated files as per issues - Build Python fails due to Zap Generation on Raspberry Pi (no ARM based version of zap-cli available) project-chip#24718 * Updated matter guide explaining how to use additional args for pregenerated code * fixed misspelling of Raspberry as picked up by reviewdog in CI tests * updated guide to state which things need to be pregenerated * added more information to the matter-repl.md file on pregeneration * fixed spelling mistakes such as pregeneration, pregenerated, pregen * patched with what the restyler is suggesting * Restyled by prettier-markdown --------- Co-authored-by: oidebrett <ivob@DESKTOP-J0S44C6.localdomain> Co-authored-by: oidebrett <oidebrett@lccgmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified build_python.sh to take argument to use pregenerated files as per issue #24718 - Build Python fails due to Zap Generation on Raspberry Pi (no ARM based version of zap-cli available). Alos updated matter-repl.md to explain how to use