-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in src/app/tests/suites/certifications/[Test_TC_MEDIAPLAYBACK_6_*|Test_TC_ACE_1_1].yaml #24750
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Typos_VariousTestsWithYamlTestsParser_attempt4
Jan 31, 2023
Merged
Fix typos in src/app/tests/suites/certifications/[Test_TC_MEDIAPLAYBACK_6_*|Test_TC_ACE_1_1].yaml #24750
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Typos_VariousTestsWithYamlTestsParser_attempt4
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
Typos_VariousTestsWithYamlTestsParser_attempt4
branch
from
January 31, 2023 10:03
ac7e451
to
d45944f
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
ksperling-apple
January 31, 2023 10:04
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pjzander-signify,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 31, 2023 10:04
…CK_6_*|Test_TC_ACE_1_1].yaml
vivien-apple
force-pushed
the
Typos_VariousTestsWithYamlTestsParser_attempt4
branch
from
January 31, 2023 10:11
d45944f
to
f92e48c
Compare
PR #24750: Size comparison from 210ae33 to f92e48c Increases (6 builds for esp32, linux, psoc6, telink)
Decreases (8 builds for k32w, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Jan 31, 2023
bzbarsky-apple
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to CI catching this....
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…CK_6_*|Test_TC_ACE_1_1].yaml (project-chip#24750) * Fix typos in src/app/tests/suites/certifications/[Test_TC_MEDIAPLAYBACK_6_*|Test_TC_ACE_1_1].yaml * Update generated tests content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some new
Test_TC_MEDIAPLAYBACK
yaml tests have been introduced recently and they do contains typos.Test_TC_ACE_1_1
also contains areturns
instead of aresponse
.Fixing those makes the tests generated content happier.