Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Move WebSocketServer code to src/app/tests/suites/server … #24617

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[chip-tool] Move WebSocketServer code to src/app/tests/suites/server … #24617

merged 1 commit into from
Jan 25, 2023

Conversation

vivien-apple
Copy link
Contributor

…so it can be reused

Problem

This PR just moves chip-tool web socket server code to a place where other apps can used it.

@vivien-apple vivien-apple self-assigned this Jan 24, 2023
@vivien-apple vivien-apple force-pushed the WebSocketServer_as_component branch from 80f4899 to 828f546 Compare January 24, 2023 13:51
@github-actions
Copy link

github-actions bot commented Jan 24, 2023 •
edited
Loading

PR #24617: Size comparison from 9de347f to 828f546

Increases (6 builds for bl702, esp32, linux, telink)
platform target config section 9de347f 828f546 change % change
bl702 lighting-app bl702 (read/write) 1184935 1184951 16 0.0
.debug_info 40197392 40197393 1 0.0
.text 952352 952354 2 0.0
esp32 all-clusters-app c3devkit (read only) 1041544 1041546 2 0.0
.flash.text 1041544 1041546 2 0.0
linux chip-tool debug (read only) 11573441 11573489 48 0.0
.rodata 642961 643005 44 0.0
chip-tool-ipv6only arm64 (read only) 10961580 10961612 32 0.0
.rodata 568732 568764 32 0.0
telink ota-requestor-app tlsr9518adk80d (read/write) 899532 899540 8 0.0
text 608288 608290 2 0.0
thermostat tlsr9518adk80d text 597938 597940 2 0.0
Decreases (8 builds for bl602, bl702, cyw30739, nrfconnect, psoc6, telink)
platform target config section 9de347f 828f546 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345482 -8 -0.0
.text 1022522 1022518 -4 -0.0
bl702 lighting-app bl702+rpc .debug_info 44593732 44593731 -1 -0.0
.text 1029344 1029342 -2 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550766 550758 -8 -0.0
.app_xip_area 432272 432264 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 773940 773936 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27473457 27473455 -2 -0.0
lock cy8ckit_062s2_43012 .debug_info 22711007 22711005 -2 -0.0
telink all-clusters-app tlsr9518adk80d text 688800 688798 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 652284 652282 -2 -0.0
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 9de347f 828f546 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345482 -8 -0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022522 1022518 -4 -0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053454 1053454 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184935 1184951 16 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549734 1549734 0 0.0
.debug_aranges 134080 134080 0 0.0
.debug_frame 491108 491108 0 0.0
.debug_info 40197392 40197393 1 0.0
.debug_line 5266868 5266868 0 0.0
.debug_loc 3402493 3402493 0 0.0
.debug_ranges 371952 371952 0 0.0
.debug_str 3535926 3535926 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571662 571662 0 0.0
.symtab 173168 173168 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952352 952354 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698172 1698172 0 0.0
.debug_aranges 142304 142304 0 0.0
.debug_frame 518812 518812 0 0.0
.debug_info 44593732 44593731 -1 -0.0
.debug_line 5665193 5665193 0 0.0
.debug_loc 3598687 3598687 0 0.0
.debug_ranges 395656 395656 0 0.0
.debug_str 3939235 3939235 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632259 632259 0 0.0
.symtab 191520 191520 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029344 1029342 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677223 0 0.0
(read/write) 174632 174632 0 0.0
.bss 81548 81548 0 0.0
.data 3384 3384 0 0.0
.rodata 87471 87471 0 0.0
.text 589440 589440 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640847 640847 0 0.0
(read/write) 158240 158240 0 0.0
.bss 80740 80740 0 0.0
.data 3384 3384 0 0.0
.rodata 77423 77423 0 0.0
.text 563100 563100 0 0.0
lock-ftd LP_CC2652R7 (read only) 674347 674347 0 0.0
(read/write) 174980 174980 0 0.0
.bss 79108 79108 0 0.0
.data 3312 3312 0 0.0
.rodata 76267 76267 0 0.0
.text 597600 597600 0 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660663 0 0.0
(read/write) 183928 183928 0 0.0
.bss 74372 74372 0 0.0
.data 3312 3312 0 0.0
.rodata 102735 102735 0 0.0
.text 557448 557448 0 0.0
pump-app LP_CC2652R7 (read only) 687379 687379 0 0.0
(read/write) 162676 162676 0 0.0
.bss 79068 79068 0 0.0
.data 3276 3276 0 0.0
.rodata 90395 90395 0 0.0
.text 596504 596504 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672811 0 0.0
(read/write) 177356 177356 0 0.0
.bss 79180 79180 0 0.0
.data 3300 3300 0 0.0
.rodata 86475 86475 0 0.0
.text 585856 585856 0 0.0
shell LP_CC2652R7 (read only) 668494 668494 0 0.0
(read/write) 185432 185432 0 0.0
.bss 83620 83620 0 0.0
.data 3380 3380 0 0.0
.rodata 84206 84206 0 0.0
.text 583972 583972 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585402 0 0.0
.app_xip_area 461420 461420 0 0.0
.bss 66432 66432 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589118 589118 0 0.0
.app_xip_area 459840 459840 0 0.0
.bss 71720 71720 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550766 550758 -8 -0.0
.app_xip_area 432272 432264 -8 -0.0
.bss 60984 60984 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974240 974240 0 0.0
.bss 147144 147144 0 0.0
.data 2196 2196 0 0.0
.text 824880 824880 0 0.0
BRD4161A+rs911x (read/write) 1037308 1037308 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853616 853616 0 0.0
BRD4187C (read/write) 1151392 1151392 0 0.0
.bss 133644 133644 0 0.0
.data 2544 2544 0 0.0
.text 990608 990608 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064932 1064932 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909712 909712 0 0.0
window-app BRD4187C (read/write) 1144108 1144108 0 0.0
.bss 135060 135060 0 0.0
.data 2568 2568 0 0.0
.text 981884 981884 0 0.0
esp32 all-clusters-app c3devkit (read only) 1041544 1041546 2 0.0
(read/write) 1515938 1515938 0 0.0
.dram0.bss 75904 75904 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220024 220024 0 0.0
.flash.text 1041544 1041546 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1093747 1093747 0 0.0
(read/write) 497607 497607 0 0.0
.dram0.bss 80952 80952 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248812 248812 0 0.0
.flash.text 1088363 1088363 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660908 660908 0 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562324 562324 0 0.0
light k32w0+release (read/write) 672820 672820 0 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592884 592884 0 0.0
lock k32w0+release (read/write) 632288 632288 0 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551564 551564 0 0.0
linux all-clusters-app debug (read only) 3148537 3148537 0 0.0
(read/write) 154736 154736 0 0.0
.bss 63616 63616 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283339 283339 0 0.0
.text 2679778 2679778 0 0.0
all-clusters-minimal-app debug (read only) 2961625 2961625 0 0.0
(read/write) 147952 147952 0 0.0
.bss 62752 62752 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282059 282059 0 0.0
.text 2497474 2497474 0 0.0
bridge-app debug (read only) 2524681 2524681 0 0.0
(read/write) 132320 132320 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68952 68952 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 213920 213920 0 0.0
.text 2138370 2138370 0 0.0
chip-tool debug (read only) 11573441 11573489 48 0.0
(read/write) 647376 647376 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 611296 611296 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 642961 643005 44 0.0
.text 9430820 9430820 0 0.0
chip-tool-ipv6only arm64 (read only) 10961580 10961612 32 0.0
(read/write) 696696 696696 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 640120 640120 0 0.0
.dynamic 560 560 0 0.0
.got 14112 14112 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 568732 568764 32 0.0
.text 8743284 8743284 0 0.0
lighting-app debug+rpc (read only) 2692129 2692129 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229856 229856 0 0.0
.text 2284914 2284914 0 0.0
lock-app debug (read only) 2650985 2650985 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246056 246056 0 0.0
.text 2232418 2232418 0 0.0
ota-provider-app debug (read only) 2224945 2224945 0 0.0
(read/write) 106480 106480 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51560 51560 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197448 197448 0 0.0
.text 1886978 1886978 0 0.0
ota-requestor-app debug (read only) 2386441 2386441 0 0.0
(read/write) 114208 114208 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56328 56328 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204400 204400 0 0.0
.text 2032498 2032498 0 0.0
shell debug (read only) 2681073 2681073 0 0.0
(read/write) 139232 139232 0 0.0
.bss 59016 59016 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241490 241490 0 0.0
.text 2279138 2279138 0 0.0
thermostat-no-ble arm64 (read only) 2503556 2503556 0 0.0
(read/write) 144648 144648 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150816 150816 0 0.0
.text 2090944 2090944 0 0.0
tv-app debug (read only) 3315089 3315089 0 0.0
(read/write) 259568 259568 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78096 78096 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270520 270520 0 0.0
.text 2849842 2849842 0 0.0
tv-casting-app debug (read only) 5693161 5693161 0 0.0
(read/write) 162264 162264 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 100216 100216 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365300 365300 0 0.0
.text 5049202 5049202 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463192 2463192 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425836 1425836 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164968 1164968 0 0.0
bss 147118 147118 0 0.0
rodata 133232 133232 0 0.0
text 804400 804400 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366544 1366544 0 0.0
bss 106418 106418 0 0.0
rodata 210720 210720 0 0.0
text 763568 763568 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110692 1110692 0 0.0
bss 146274 146274 0 0.0
rodata 110380 110380 0 0.0
text 773940 773936 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840944 0 0.0
(read/write) 1749972 1749972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189736 189736 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1251027 1251027 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373716 373716 0 0.0
.debug_info 27473457 27473455 -2 -0.0
.debug_line 3767340 3767340 0 0.0
.debug_loc 3652502 3652502 0 0.0
.debug_ranges 357424 357424 0 0.0
.debug_str 3485170 3485170 0 0.0
.heap 840944 840944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575773 575773 0 0.0
.symtab 423440 423440 0 0.0
.text 0 0 0 0.0
1549184 1549184 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841752 0 0.0
(read/write) 1691372 1691372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188928 188928 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1236738 1236738 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376160 376160 0 0.0
.debug_info 27031064 27031064 0 0.0
.debug_line 3775626 3775626 0 0.0
.debug_loc 3636231 3636231 0 0.0
.debug_ranges 355392 355392 0 0.0
.debug_str 3470979 3470979 0 0.0
.heap 841752 841752 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536281 536281 0 0.0
.symtab 408432 408432 0 0.0
.text 1491392 1491392 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611148 1611148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071778 1071778 0 0.0
.debug_aranges 102824 102824 0 0.0
.debug_frame 346720 346720 0 0.0
.debug_info 22490390 22490390 0 0.0
.debug_line 3339769 3339769 0 0.0
.debug_loc 3337009 3337009 0 0.0
.debug_ranges 319464 319464 0 0.0
.debug_str 3275610 3275610 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474042 474042 0 0.0
.symtab 377600 377600 0 0.0
.text 1419360 1419360 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645212 1645212 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073126 1073126 0 0.0
.debug_aranges 103208 103208 0 0.0
.debug_frame 348520 348520 0 0.0
.debug_info 22711007 22711005 -2 -0.0
.debug_line 3341542 3341542 0 0.0
.debug_loc 3358628 3358628 0 0.0
.debug_ranges 321320 321320 0 0.0
.debug_str 3292017 3292017 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476977 476977 0 0.0
.symtab 379424 379424 0 0.0
.text 1448440 1448440 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148304 0 0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595404 595404 0 0.0
lock-app qpg6105+debug (read/write) 1115992 1115992 0 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563088 563088 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026616 1026616 0 0.0
bss 98552 98552 0 0.0
text 688800 688798 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964972 964972 0 0.0
bss 97696 97696 0 0.0
text 652284 652282 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869244 869244 0 0.0
bss 89844 89844 0 0.0
text 582574 582574 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 885700 885700 0 0.0
bss 89940 89940 0 0.0
text 597176 597176 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964044 964044 0 0.0
bss 97996 97996 0 0.0
text 663180 663180 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899532 899540 8 0.0
bss 90888 90888 0 0.0
text 608288 608290 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888916 888916 0 0.0
bss 91328 91328 0 0.0
text 597938 597940 2 0.0

@yufengwangca
Copy link
Contributor

src/app is taken as part of Matter core SDK in coverage statistic, if WebSocketServer is only reused by example apps, why not move to some place under examples, such as examples/common?

@vivien-apple
Copy link
Contributor Author

src/app is taken as part of Matter core SDK in coverage statistic, if WebSocketServer is only reused by example apps, why not move to some place under examples, such as examples/common?

src/app/tests/suites/ has since a long time be a place where code related to the test harness lives. If that is really an issue I believe I can moved it to examples/common...

@yufengwangca
Copy link
Contributor

src/app is taken as part of Matter core SDK in coverage statistic, if WebSocketServer is only reused by example apps, why not move to some place under examples, such as examples/common?

src/app/tests/suites/ has since a long time be a place where code related to the test harness lives. If that is really an issue I believe I can moved it to examples/common...

Currently, WebSocketServer is under 'examples/chip-tool/commands/interactive', so I think this is not used only for the testing.

The idea is we want to set a clear boundary between the example code and core SDK code, we conducts daily coverage statistic for Matter Core SDK for our internal reference, we don't count the code coverage in the examples now, so it is better to keep all example code outside of core SDK directories.

@vivien-apple vivien-apple force-pushed the WebSocketServer_as_component branch from 828f546 to 49e348f Compare January 25, 2023 09:21
@vivien-apple
Copy link
Contributor Author

src/app is taken as part of Matter core SDK in coverage statistic, if WebSocketServer is only reused by example apps, why not move to some place under examples, such as examples/common?

src/app/tests/suites/ has since a long time be a place where code related to the test harness lives. If that is really an issue I believe I can moved it to examples/common...

Currently, WebSocketServer is under 'examples/chip-tool/commands/interactive', so I think this is not used only for the testing.

The idea is we want to set a clear boundary between the example code and core SDK code, we conducts daily coverage statistic for Matter Core SDK for our internal reference, we don't count the code coverage in the examples now, so it is better to keep all example code outside of core SDK directories.

I have moved the component in examples/common...

@github-actions
Copy link

github-actions bot commented Jan 25, 2023 •
edited
Loading

PR #24617: Size comparison from 6e12e92 to 49e348f

Increases (10 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, psoc6, telink)
platform target config section 6e12e92 49e348f change % change
bl602 lighting-app bl602 (read/write) 1345482 1345490 8 0.0
.text 1022520 1022522 2 0.0
bl602+rpc .text 1053454 1053456 2 0.0
bl702 lighting-app bl702+rpc .debug_info 44587089 44587090 1 0.0
.text 1029342 1029344 2 0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 185432 185440 8 0.0
linux chip-tool-ipv6only arm64 (read only) 10960732 10960780 48 0.0
.rodata 568716 568764 48 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 773936 773940 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27465099 27465101 2 0.0
lock cy8ckit_062s2_43012 .debug_info 22704397 22704398 1 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1026608 1026616 8 0.0
text 688796 688798 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 652282 652284 2 0.0
Decreases (6 builds for cc13x2_26x2, esp32, telink)
platform target config section 6e12e92 49e348f change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 668494 668486 -8 -0.0
.text 583972 583964 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1041546 1041542 -4 -0.0
.flash.text 1041546 1041542 -4 -0.0
m5stack (read/write) 497607 497603 -4 -0.0
.flash.rodata 248812 248808 -4 -0.0
telink light-switch-app tlsr9518adk80d text 597178 597176 -2 -0.0
ota-requestor-app tlsr9518adk80d text 608288 608286 -2 -0.0
thermostat tlsr9518adk80d text 597938 597936 -2 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6e12e92 49e348f change % change
bl602 lighting-app bl602 (read/write) 1345482 1345490 8 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022520 1022522 2 0.0
bl602+rpc (read/write) 1390930 1390930 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053454 1053456 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184951 1184951 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549734 1549734 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 491000 491000 0 0.0
.debug_info 40190809 40190809 0 0.0
.debug_line 5266055 5266055 0 0.0
.debug_loc 3401794 3401794 0 0.0
.debug_ranges 371904 371904 0 0.0
.debug_str 3535090 3535090 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106704 106704 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571662 571662 0 0.0
.symtab 173168 173168 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952354 952354 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277579 1277579 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698172 1698172 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518704 518704 0 0.0
.debug_info 44587089 44587090 1 0.0
.debug_line 5664380 5664380 0 0.0
.debug_loc 3597945 3597945 0 0.0
.debug_ranges 395608 395608 0 0.0
.debug_str 3938399 3938399 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121232 121232 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632259 632259 0 0.0
.symtab 191520 191520 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029342 1029344 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677223 677223 0 0.0
(read/write) 174632 174632 0 0.0
.bss 81548 81548 0 0.0
.data 3384 3384 0 0.0
.rodata 87471 87471 0 0.0
.text 589440 589440 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640847 640847 0 0.0
(read/write) 158240 158240 0 0.0
.bss 80740 80740 0 0.0
.data 3384 3384 0 0.0
.rodata 77423 77423 0 0.0
.text 563100 563100 0 0.0
lock-ftd LP_CC2652R7 (read only) 674347 674347 0 0.0
(read/write) 174980 174980 0 0.0
.bss 79108 79108 0 0.0
.data 3312 3312 0 0.0
.rodata 76267 76267 0 0.0
.text 597600 597600 0 0.0
lock-mtd LP_CC2652R7 (read only) 660663 660663 0 0.0
(read/write) 183928 183928 0 0.0
.bss 74372 74372 0 0.0
.data 3312 3312 0 0.0
.rodata 102735 102735 0 0.0
.text 557448 557448 0 0.0
pump-app LP_CC2652R7 (read only) 687379 687379 0 0.0
(read/write) 162676 162676 0 0.0
.bss 79068 79068 0 0.0
.data 3276 3276 0 0.0
.rodata 90395 90395 0 0.0
.text 596504 596504 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672811 0 0.0
(read/write) 177356 177356 0 0.0
.bss 79180 79180 0 0.0
.data 3300 3300 0 0.0
.rodata 86475 86475 0 0.0
.text 585856 585856 0 0.0
shell LP_CC2652R7 (read only) 668494 668486 -8 -0.0
(read/write) 185432 185440 8 0.0
.bss 83620 83620 0 0.0
.data 3380 3380 0 0.0
.rodata 84206 84206 0 0.0
.text 583972 583964 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585402 585402 0 0.0
.app_xip_area 461420 461420 0 0.0
.bss 66432 66432 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589118 589118 0 0.0
.app_xip_area 459840 459840 0 0.0
.bss 71720 71720 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550766 550766 0 0.0
.app_xip_area 432272 432272 0 0.0
.bss 60984 60984 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974240 974240 0 0.0
.bss 147144 147144 0 0.0
.data 2196 2196 0 0.0
.text 824880 824880 0 0.0
BRD4161A+rs911x (read/write) 1037308 1037308 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853616 853616 0 0.0
BRD4187C (read/write) 1151392 1151392 0 0.0
.bss 133644 133644 0 0.0
.data 2544 2544 0 0.0
.text 990608 990608 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064932 1064932 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909712 909712 0 0.0
window-app BRD4187C (read/write) 1144108 1144108 0 0.0
.bss 135060 135060 0 0.0
.data 2568 2568 0 0.0
.text 981884 981884 0 0.0
esp32 all-clusters-app c3devkit (read only) 1041546 1041542 -4 -0.0
(read/write) 1515938 1515938 0 0.0
.dram0.bss 75904 75904 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220024 220024 0 0.0
.flash.text 1041546 1041542 -4 -0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1093759 1093759 0 0.0
(read/write) 497607 497603 -4 -0.0
.dram0.bss 80952 80952 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248812 248808 -4 -0.0
.flash.text 1088375 1088375 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660908 660908 0 0.0
.bss 77360 77360 0 0.0
.data 2112 2112 0 0.0
.text 562324 562324 0 0.0
light k32w0+release (read/write) 672820 672820 0 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592884 592884 0 0.0
lock k32w0+release (read/write) 632288 632288 0 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 551564 551564 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10960732 10960780 48 0.0
(read/write) 696664 696664 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 640096 640096 0 0.0
.dynamic 560 560 0 0.0
.got 14112 14112 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 568716 568764 48 0.0
.text 8742484 8742484 0 0.0
thermostat-no-ble arm64 (read only) 2503556 2503556 0 0.0
(read/write) 144648 144648 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76944 76944 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150816 150816 0 0.0
.text 2090944 2090944 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463192 2463192 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425836 1425836 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164968 1164968 0 0.0
bss 147118 147118 0 0.0
rodata 133232 133232 0 0.0
text 804400 804400 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366544 1366544 0 0.0
bss 106418 106418 0 0.0
rodata 210720 210720 0 0.0
text 763568 763568 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110692 1110692 0 0.0
bss 146274 146274 0 0.0
rodata 110380 110380 0 0.0
text 773936 773940 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840944 0 0.0
(read/write) 1749972 1749972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189736 189736 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1251009 1251009 0 0.0
.debug_aranges 111256 111256 0 0.0
.debug_frame 373620 373620 0 0.0
.debug_info 27465099 27465101 2 0.0
.debug_line 3766626 3766626 0 0.0
.debug_loc 3651664 3651664 0 0.0
.debug_ranges 357376 357376 0 0.0
.debug_str 3484013 3484013 0 0.0
.heap 840944 840944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575760 575760 0 0.0
.symtab 423440 423440 0 0.0
.text 1549184 1549184 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841752 0 0.0
(read/write) 1691372 1691372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188928 188928 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1236720 1236720 0 0.0
.debug_aranges 110520 110520 0 0.0
.debug_frame 376064 376064 0 0.0
.debug_info 27022864 27022864 0 0.0
.debug_line 3774912 3774912 0 0.0
.debug_loc 3635394 3635394 0 0.0
.debug_ranges 355344 355344 0 0.0
.debug_str 3469766 3469766 0 0.0
.heap 841752 841752 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536226 536226 0 0.0
.symtab 408432 408432 0 0.0
.text 1491392 1491392 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611148 1611148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071778 1071778 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22483781 22483781 0 0.0
.debug_line 3339092 3339092 0 0.0
.debug_loc 3336402 3336402 0 0.0
.debug_ranges 319416 319416 0 0.0
.debug_str 3274787 3274787 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474042 474042 0 0.0
.symtab 377600 377600 0 0.0
.text 1419360 1419360 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645212 1645212 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073126 1073126 0 0.0
.debug_aranges 103184 103184 0 0.0
.debug_frame 348424 348424 0 0.0
.debug_info 22704397 22704398 1 0.0
.debug_line 3340859 3340859 0 0.0
.debug_loc 3357990 3357990 0 0.0
.debug_ranges 321272 321272 0 0.0
.debug_str 3291194 3291194 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476977 476977 0 0.0
.symtab 379424 379424 0 0.0
.text 1448440 1448440 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148304 1148304 0 0.0
.bss 100668 100668 0 0.0
.data 848 848 0 0.0
.text 595404 595404 0 0.0
lock-app qpg6105+debug (read/write) 1115992 1115992 0 0.0
.bss 97188 97188 0 0.0
.data 860 860 0 0.0
.text 563088 563088 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026608 1026616 8 0.0
bss 98552 98552 0 0.0
text 688796 688798 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964972 964972 0 0.0
bss 97696 97696 0 0.0
text 652282 652284 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869244 869244 0 0.0
bss 89844 89844 0 0.0
text 582574 582574 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 885700 885700 0 0.0
bss 89940 89940 0 0.0
text 597178 597176 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964044 964044 0 0.0
bss 97996 97996 0 0.0
text 663180 663180 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899532 899532 0 0.0
bss 90888 90888 0 0.0
text 608288 608286 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888916 888916 0 0.0
bss 91328 91328 0 0.0
text 597938 597936 -2 -0.0

@andy31415 andy31415 merged commit e67ccf5 into project-chip:master Jan 25, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
[chip-tool] Move WebSocketServer code to src/app/tests/suites/server …
80c62ef 
…so it can be reused (project-chip#24617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
examples review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @yufengwangca @andy31415 @bzbarsky-apple