-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Add a command line option to disable sending of NotifyUpdateApplied command #24575
Merged
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_cli_notify_update
Jan 23, 2023
Merged
[OTA] Add a command line option to disable sending of NotifyUpdateApplied command #24575
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_requestor_cli_notify_update
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24575: Size comparison from 8f926b8 to ffe8afb Increases above 0.2%:
Increases (24 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect, qpg, telink)
Decreases (7 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 23, 2023
bzbarsky-apple
approved these changes
Jan 23, 2023
ffe8afb
to
b635289
Compare
b635289
to
293628c
Compare
PR #24575: Size comparison from 35ac9cf to 293628c Increases above 0.2%:
Increases (24 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command line option to linux ota-requestor-app to disable sending of NotifyUpdateApplied command. By default this is always sent after a successful update. For testing purpose, this option is helpful in validating cases where this optional command is not sent after update.