[mrp] Increase MRP intervals for Thread #24549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the default MRP parameters for Thread devices from 300 to 800ms. Also, apply the retry interval boost of 500ms on the Thread sender side. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
|
PR #24549: Size comparison from 6ee19a3 to 49d006a Increases (31 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl602, cc13x2_26x2, psoc6)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 20, 2023
LuDuda
approved these changes
Jan 20, 2023
| * | ||
| * @brief | ||
| * A constant value that should be added to the calculated retransmission | ||
| * timeout when the present node tramsmits a message. |
| * timeout when the present node tramsmits a message. | ||
| * | ||
| * The purpose for this constant is to limit the possibility of spurious | ||
| * rertansmissions in the scenario in which a sender that operates in a high- |
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Increase the default MRP parameters for Thread devices from 300 to 800ms. Also, apply the retry interval boost of 500ms on the Thread sender side. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #23600.
The numbers were selected based on measurements described in report. Although the testing methodology was questioned by some people, and I would like to repeat the tests under different conditions, the current numbers seem too low for Thread devices and cause issues in our testing, so let's start with something more realistic.